cgwalters / git-evtag

Extended verification for git tags
Other
131 stars 13 forks source link

submodule lookup incorrectly assumes name matches tree entry name #47

Open benzea opened 1 year ago

benzea commented 1 year ago

The submodule lookup should take the full path of the tree entry (not just the entry name itself) and it should then find the matching submodule. Note that the name of a submodule by default is its path, but this might not be the case.

I am running into a problem with this in SDAPS (https://github.com/sdaps/sdaps/blob/master/.gitmodules). The module is called "tex/class" with the same path. But, evtag looks for "class".

In this case, I can easily work around that by renaming the submodule to "class" (maybe I will do that). But, I guess one could theoretically have two submodules with the same tree entry name in two different parts of the tree ...