ch-nry / VCV_nozori

port of nozori eurorack module for VCV Rack
GNU General Public License v3.0
15 stars 2 forks source link

"This module need 96 kHz" message does not disappear #11

Closed Elias035 closed 4 years ago

Elias035 commented 4 years ago

All the modules have the same issue. I tried changing to 96kHz, restarting Rack, saving and reloading the patch with 96kHz. Is this meant to happen?

I'm using Rack 1.1.6, the modules are 1.1.5, I am running MacOS Catalina 10.15.4.

ch-nry commented 4 years ago

no, it's not. The message should disappear after few second when using the wrong sample rate, and should never appear when using the correct sample rate. It's a bug I can't reproduce here, and I don't know how to fix.

Elias035 commented 4 years ago

Hey. Thanks for making this clear and sharing your work with the community. Dont worry about it, I just wanted to share the information. No need to fix this of you dont feel it is beneficial.

Happy and healthy times. Elias

On 9. May 2020, at 11.00, cyrille henry notifications@github.com wrote:

 no, it's not. The message should disappear after few second when using the wrong sample rate, and should never appear when using the correct sample rate. It's a bug I can't reproduce here, and I don't know how to fix.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

ch-nry commented 4 years ago

I would like to fix this problem, but I don't know how. Transparency is only experimental in VCV rack...

best

jaortega-net commented 4 years ago

Hi. I have the same issue. I can tell that first time i tried to use nozoid modules, rack was in 44.1 but changed it cause 96 is the freq i work with. So all later sessions were in 96 and still saying that needs what the actual sampling rate is. I have unsubsribed, deleted nozoid folder plugins, subscribed again and update rack. Doesnt work. 1.1.6 on catalina too.

Thank you so much.

ch-nry commented 4 years ago

thanks for the report, It look like it' a problem between VCV alpha channel with catalina...

joshdavenport commented 4 years ago

Also seeing this issue in Catalina 10.15.4 with VCV 1.1.6

image

Anything I could do to help debug?

ch-nry commented 4 years ago

Since this problem only appear on osX catalina, and I use linux, I don't know how to debug it. Is there a developer here that is OK to help me? You will need to compile the plug-in from source, in order to test few hypothesis...

joshdavenport commented 4 years ago

I believe I've managed to fix this. See below for the behaviour I'm now seeing from a local build. The warning is even correctly hidden in the module selection menu.

2020-08-25 22 46 07

Not sure I can fully explain how it was broken only on Catalina (or mac generally, whatever) and not on Linux. In any case, hopefully this will also work on your linux machine @ch-nry. That would be a positive sign that this will work everywhere IMO.

Creating a pull request now.

ch-nry commented 4 years ago

version 1.1.7 is available via automatic update in VCV. Is the fix working for catalina user?

joshdavenport commented 4 years ago

Yep, all good! 👍

Screenshot 2020-09-01 at 11 30 14

Screenshot 2020-09-01 at 11 30 41

ch-nry commented 4 years ago

good! I did not understand the problem, but i'm glad it's fixed. thanks!