ch-robinson / dotnet-avro

An Avro implementation for .NET
https://engineering.chrobinson.com/dotnet-avro/
MIT License
135 stars 51 forks source link

Bugfix: Handle serialization of records with a default array value #256

Closed nicodeslandes closed 1 year ago

nicodeslandes commented 1 year ago

Fixes #255

Fixes the expression used when generating a serializer for an array type of an unknown record type.

Note: I included configuration files for NCrunch (which beautifully with this project). I think it could be useful to other contributors, but I'm happy to remove them if it's too messy.

dstelljes commented 1 year ago

Thanks for chasing this down! Please do back out the NCrunch changes (for now, at least) and we’ll get this merged.

nicodeslandes commented 1 year ago

Pleasure! So sad for NCrunch... 😄 I have rolled back the changes around it, so hopefully we're good to go