search

ch11ng / exwm

Emacs X Window Manager
2.85k stars 134 forks source link

`exwm-mode-map` hard codes keybindings (cf. ["Toggle mode-line" exwm-layout-toggle-mode-line :keys "C-c C-t C-m"]) #605

Closed emacksnotes closed 5 years ago

emacksnotes commented 5 years ago

Based on EXWM User Guide: Local Key Bindings, I had disabled the C-c prefix keys with

(define-key exwm-mode-map (kbd "C-c") nil)

Even then, the EXWM menu entry was indicating that mode line could be toggled withC-c C-t C-m. I was confused, because I had /explicitly/ disallowed C-c prefix bindings.

On further investigation, I noticed that exwm-mode-map (cf. exwm-core.el#L254, hard-codes the kebinding like so

["Toggle mode-line" exwm-layout-toggle-mode-line :keys "C-c C-t C-m"]

Why is the need for hard-coding of keys, when Emacs itself takes care of inserting a suitable suggestion based on user's active configuration.

ch11ng commented 5 years ago

Perhaps it was to make C-m rendered as C-m rather than RET (though they are the same). It turns out to be a bad idea. I'll remove them.

ch11ng commented 5 years ago

Done.