make-network-process arguments for sockets changed in emacs 25

ch11ng / xelb

X protocol Emacs Lisp Binding

216 stars 21 forks source link

make-network-process arguments for sockets changed in emacs 25 #14

Closed avoine closed 5 years ago

avoine commented 7 years ago

in xcb:connect-to-socket at https://github.com/ch11ng/xelb/blob/master/xcb.el#L186 I think make-network-process needs to have arguments: :family 'local :service socket instead of :remote socket

ch11ng commented 7 years ago

I'm not sure which Emacs version you were exactly referring, but for the current emacs-25 branch the address family is automatically recognized as 'local when :remote is set to a string (see https://github.com/emacs-mirror/emacs/blob/emacs-25/src/process.c#L3184-L3196). What's the advantage of using those two arguments?

ch11ng commented 5 years ago

Hi, since XELB seems to run well on Emacs up to version 27, I'm closing this issue now.