search

ch4mpy / spring-addons

Ease spring OAuth2 resource-servers configuration and testing
Apache License 2.0
532 stars 87 forks source link

JDK-Suffix breaks semver contract #39

Closed mrohlof-protofy closed 2 years ago

mrohlof-protofy commented 2 years ago

Describe the bug Not necessarily a bug in the library itself, but an inconvenience in the interaction with other tools:

I use this library as jdk-11 Dependency. Update mechanisms like dependabot think the jdk-17 variant is newer than jdk-11 and try to bump versions to it. Please think about re-structuring your naming scheme such that the jdk ist part of group or artifact id instead of version. I would prefer to see this:

    <groupId>com.c4-soft.springaddons</groupId>
    <artifactId>spring-security-oauth2-test-webmvc-addons-jdk11</artifactId>
    <version>3.1.16</version>

// Edit: This also goes for mvnrepository itself. See https://mvnrepository.com/artifact/com.c4-soft.springaddons/spring-security-oauth2-test-webmvc-addons/3.1.16-jdk11 for example

Note: There is a new version for this artifact. New Version 3.1.16-jdk17

ch4mpy commented 2 years ago

I'll give an other try to releasing with classifier.

Anyhow, multi JDK build (which is a pain for me to do) will disapear when moving to spring-boot 3: builds will be done with JDK 17 only.

ch4mpy commented 2 years ago

Fixed with 3.2.0

-jdk1.8 and -jdk11 artifacts might drift in functionality from JDK 17 flavor (one branch per JDK version => need to manually patch branches when updating master)