search

chStaiger / iBridges-Gui

A graphical user interface to iRODS employing the iBridges python package.
https://chstaiger.github.io/iBridges-Gui/
GNU General Public License v3.0
15 stars 8 forks source link

189 improve sync #191

Closed chStaiger closed 3 months ago

chStaiger commented 3 months ago
qubixes commented 3 months ago

More feedback:

chStaiger commented 3 months ago

A lot has been done again!! From clicking the buttons: Currently the listing of the remote collections seems slow (slower than when I'm using the CLI). Also, the size of the ibridges window was too small and the synchronize button disappeared, which left me confused. Perhaps the minimum size needs to be updated? The live updates of the transfer is nice!

The loading of the iRODS tree is much faster since I only load it now layer by layer, not two layers when the user expands the tree.

The sync function might be slower since I am actually using the upload and download function with the dry-run dictionary from the sync. I checked the code, there are no superfluous things in there. The emit function might make it slower, this is the function that emits the status as a string. And I am calling the upload/download function per item in the sync dictionary.

chStaiger commented 3 months ago

More feedback:

  • The counter seems to start at 2 and finish with n+1.

Fixed, I indeed started counting at 1. tstststs.

  • The synchronization is really slow: ~48s for the CLI and 86s for the GUI for the same collection (download). I tried the CLI twice and it was within 1 second.

Yes, but I could not spot anything obvious at the moment ...

  • It would be nice to have a cancel functionality, but this is probably a different PR.

Indeed, but it has to wait a bit ;)