GUI style color scheme - Githubissues

chStaiger commented 3 months ago

Added new color scheme
Added logo
Small bugfixes: the sorting of the table disturbed the correct loading of the table in browser --> switched off
Emit when creating folders and collections in DataTransferThread

maartenschermer commented 3 months ago

Not sure if these were introduced in this PR, but I found a few small bugs:

BROWSER: when I upload an existing file with Overwrite checked, it fails; logs:

ValueError: max() iterable argument is empty
2024-06-12 16:09:24,510 - ibridges-gui - ERROR - Downloading /nluu12p/home/research-test-christine/MDS/comicbooks/GB-2020-x-x-a-1-I.pdf failed: max() iterable argument is empty
Traceback (most recent call last):
File "/home/maarten/anaconda3/envs/ibridges/lib/python3.12/site-packages/ibridgesgui/browser.py", line 183, in download
download(self.session, path, download_dir, overwrite=overwrite)
File "/home/maarten/anaconda3/envs/ibridges/lib/python3.12/site-packages/ibridges/data_operations.py", line 320, in download
perform_operations(session, ops, ignore_err=ignore_err)
File "/home/maarten/anaconda3/envs/ibridges/lib/python3.12/site-packages/ibridges/data_operations.py", line 382, in perform_operations
max_size = max([*up_sizes, *down_sizes])
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

SYNC: there's no values in the 'Size in bytes' column of the list with files-top-be-synched.
SYNC: creating a local folder that already exists gives an "Insufficient rights"-error rather than "Folder already exists"
SYNC: when creating a collection, the full path of the created collection is too long for the dialog and unreadable.

I've got some other ideas & suggestions, but these are the only bugs I ran into.

chStaiger commented 3 months ago

Not sure if these were introduced in this PR, but I found a few small bugs:

* BROWSER: when I upload an existing file with Overwrite checked, it fails; logs:

ValueError: max() iterable argument is empty
2024-06-12 16:09:24,510 - ibridges-gui - ERROR - Downloading /nluu12p/home/research-test-christine/MDS/comicbooks/GB-2020-x-x-a-1-I.pdf failed: max() iterable argument is empty
Traceback (most recent call last):
  File "/home/maarten/anaconda3/envs/ibridges/lib/python3.12/site-packages/ibridgesgui/browser.py", line 183, in download
    download(self.session, path, download_dir, overwrite=overwrite)
  File "/home/maarten/anaconda3/envs/ibridges/lib/python3.12/site-packages/ibridges/data_operations.py", line 320, in download
    perform_operations(session, ops, ignore_err=ignore_err)
  File "/home/maarten/anaconda3/envs/ibridges/lib/python3.12/site-packages/ibridges/data_operations.py", line 382, in perform_operations
    max_size = max([*up_sizes, *down_sizes])
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

* SYNC: there's no values in the 'Size in bytes' column of the list with files-top-be-synched.

* SYNC: creating a local folder that already exists gives an "Insufficient rights"-error rather than "Folder already exists"

* SYNC: when creating a collection, the full path of the created collection is too long for the dialog and unreadable.

I've got some other ideas & suggestions, but these are the only bugs I ran into.

Yes I found them too. They are caused by the backend and there is already an issue for it https://github.com/UtrechtUniversity/iBridges/issues/191

chStaiger commented 3 months ago

SYNC: creating a local folder that already exists gives an "Insufficient rights"-error rather than "Folder already exists"

Solved! thanks for finding it!

chStaiger commented 3 months ago

SYNC: when creating a collection, the full path of the created collection is too long for the dialog and unreadable.

Solved by using a differnt text widget

chStaiger / iBridges-Gui

GUI style color scheme #200