search

cha55son / stash-commit-graph-plugin

The missing commit graph for Atlassian Stash/Bitbucket Server
MIT License
73 stars 34 forks source link

Allow the drawing of a diverge and merge at same point #55

Closed sambott closed 9 years ago

sambott commented 9 years ago

Hi, I use this network plugin and it's great however, there was a minor bug in the js that meant it assumed that all other routes should continue straight when drawing a merge. The scenario that a merge and branch need to be rendered at the same time occured a lot here so at the bottom of the network was loads of diconnected lines. (The scenario typically occurs when the first commit on a new branch is a merge from another branch.)

I thought I'd send you this patch in case you want to create a fix branch at the point before you started the rewrite (ie a new branch at the point I forked). If nothing else it's a fix for the others who have forked and a reference for your rewrite in case the same scenario repeats itself.

Thanks for the handy plugin!

Sam

cha55son commented 9 years ago

It seems this PR is against an older version. If possible, please update to the latest.

cha55son commented 9 years ago

@sambott thanks for the work on this. @wilfred has rebased these changes on master and seems to be working well. Therefore i'll be closing this PR.