search

chabokpush / chabok-client-rn

Chabok react native wrapper
https://doc.chabokpush.com/react-native-bridge/introducing.html
5 stars 5 forks source link

console.log calls must be removed from production build #15

Closed arastu closed 5 years ago

arastu commented 5 years ago

console.log() statements are really handy tools for JavaScript development, but I think it must delete on the production build. https://github.com/chabokpush/chabok-client-rn/blob/35c334fd0aea5410b83488ff4ede4ec5478ebb65/lib/modules/core/chabok.js#L15 If you remove console log expression you can remove constructor method too, because when you do not specify a constructor method a default constructor is used.

amir-yaghoubi commented 5 years ago

@arastu you are right about this, we will resolve this issue in next release. https://github.com/chabokpush/chabok-client-rn/commit/acd878cbc53cee27e8a0c3e1033c72b512f006cc