search

chabou / hyper-pane

Extension for Hyper.app to enhance pane navigation.
MIT License
191 stars 13 forks source link

Plugin error: undefined: Error occurred in `reduceTermGroups`. #3

Closed kc-dot-io closed 7 years ago

kc-dot-io commented 7 years ago

Thanks for this plugin, really needed this to get hyper up to snuff for my iterm2 replacement however I'm having an issue where it's constantly throwing an error anytime I close a vertical pane.

Please see below:

screen recording 2017-02-09 at 01 31 pm 1

chabou commented 7 years ago

Reproduced. Thank you very much for this great feedback 👌

chabou commented 7 years ago

Ok this plugin hits a Hyper issue: https://github.com/zeit/hyper/pull/1494

I will publish a protection, pending PR merge and Hyper release

kc-dot-io commented 7 years ago

@chabou Thanks! Published yet?

chabou commented 7 years ago

Just right now https://github.com/chabou/hyper-pane/releases/tag/0.1.1

kc-dot-io commented 7 years ago

Trying to verify with hpm uninstall / install hyper-pane and seeing same issue.

Where does hyper store installed modules?

kc-dot-io commented 7 years ago

Nevermind, found it in ~/.hyper_plugins/node_modules/hyper-pane

Looks like the right version. Still seeing the same issue though.

kc-dot-io commented 7 years ago

Actually, now the hotkeys do not work at all. I'll check out straight from github and confirm.

kc-dot-io commented 7 years ago

@chabou confirmed... Rolled back to 5f7818a5e183d0c66b9e570887a4d828ae6bb95f and the hotkeys are working, but still have the error.

chabou commented 7 years ago

Thank you. I rolled back npm published version to 0.1.0. It is better to have an error but the hotkeys 😆 I will finally fix that over the next couple of days

chabou commented 7 years ago

Fixed in master and release v0.1.2 But I will test it twice before push it on npm

kc-dot-io commented 7 years ago

Great! If you want; I can test it from master and confirm before you publish @chabou

On February 9, 2017 at 5:00:39 PM, CHaBou (notifications@github.com(mailto:notifications@github.com)) wrote:

Fixed in master and release v0.1.2 But I will test it twice before push it on npm

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub(https://github.com/chabou/hyper-pane/issues/3#issuecomment-278826702), or mute the thread(https://github.com/notifications/unsubscribe-auth/AABJDnQxZNsaiToX3RKK11chyPvKW74iks5ra7a3gaJpZM4L8sTn).

chabou commented 7 years ago

It would be awesome !

kc-dot-io commented 7 years ago

@chabou error is gone, so this patch works until the other one lands. Anything we need to change here when it does?

chabou commented 7 years ago

Protection will no be useful anymore. But we will keep it for backward compatibility. Thank you so much for your validation. I will publish this release soon.

chabou commented 7 years ago

Published on npm ! Thank you @slajax for your support !

kc-dot-io commented 7 years ago

very welcome @chabou - thanks for the great plugin!

freeall commented 7 years ago

@chabou I get this error when I open a new tab and then close it again. I am using version 1.0.0. Has it regressed somehow?

chabou commented 7 years ago

Reproduced !

Previous fix doesn't seem bulletproof 😛 New issue opened #4, will be fixed very soon

Thank you for your feedback