chabou / hyper-pane

Extension for Hyper.app to enhance pane navigation.
MIT License
188 stars 13 forks source link

Dimming does not work in Hyper 2.0 #36

Open jrust opened 6 years ago

jrust commented 6 years ago

I'm using Hyper 2.0 and I've tried the default setting of 0.6 for interactivePaneOpacity as well as a low value like 0.2 and am not seeing any dimming of inactive panes. Is this a known issue or am I doing something wrong? Thanks!

chabou commented 6 years ago

It works as expected for me.

Can you give me your .hyper.js config file to help me to reproduce?

jrust commented 6 years ago

Sure: https://gist.github.com/jrust/9e2bdd283cc02300139f85235dc9b39c

I'm also on Windows 10. Thanks

chabou commented 5 years ago

Sorry for the delay. It could be a conflict with other plugin (hyper-opacity ?)

jrust commented 5 years ago

Hmm, I tried removing all my plugins, but no luck. I'll keep poking around

blakejwc commented 5 years ago

@chabou I'm having the same problem with indicatorPrefix as well as inactivePaneOpacity. The only way I was able to get any configurations to change was by manually editing the index.js in the ~/.hyper_plugins/node_modules/hyper-pane directory.

Ubuntu      14.04
node        v6.7.0
npm         3.10.3
Hyper       2.1.2
hyper-pane  2.1.4

Bellow is my .hyper.js configurations, which are the same for: ~/.hyper.js ~/.config/Hyper/.hyper.js ~/.hyper_plugins/node_modules/index.js:3:defaultConfig

.hyper.js

```javascript // Future versions of Hyper may add additional config options, // which will not automatically be merged into this file. // See https://hyper.is#cfg for all currently supported options. module.exports = { config: { // choose either `'stable'` for receiving highly polished, // or `'canary'` for less polished but more frequent updates updateChannel: 'stable', // default font size in pixels for all tabs fontSize: 12, // font family with optional fallbacks fontFamily: 'Menlo, "DejaVu Sans Mono", Consolas, "Lucida Console", monospace', // default font weight: 'normal' or 'bold' fontWeight: 'normal', // font weight for bold characters: 'normal' or 'bold' fontWeightBold: 'bold', // line height as a relative unit lineHeight: 1, // letter spacing as a relative unit letterSpacing: 0, // terminal cursor background color and opacity (hex, rgb, hsl, hsv, hwb or cmyk) cursorColor: 'rgba(248,28,229,0.8)', // terminal text color under BLOCK cursor cursorAccentColor: '#000', // `'BEAM'` for |, `'UNDERLINE'` for _, `'BLOCK'` for █ cursorShape: 'BLOCK', // set to `true` (without backticks and without quotes) for blinking cursor cursorBlink: false, // color of the text foregroundColor: '#fff', // terminal background color // opacity is only supported on macOS backgroundColor: '#000', // terminal selection color selectionColor: 'rgba(248,28,229,0.3)', // border color (window, tabs) borderColor: '#333', // custom CSS to embed in the main window css: '', // custom CSS to embed in the terminal window termCSS: '', // if you're using a Linux setup which show native menus, set to false // default: `true` on Linux, `true` on Windows, ignored on macOS showHamburgerMenu: '', // set to `false` (without backticks and without quotes) if you want to hide the minimize, maximize and close buttons // additionally, set to `'left'` if you want them on the left, like in Ubuntu // default: `true` (without backticks and without quotes) on Windows and Linux, ignored on macOS showWindowControls: '', // custom padding (CSS format, i.e.: `top right bottom left`) padding: '12px 14px', // the full list. if you're going to provide the full color palette, // including the 6 x 6 color cubes and the grayscale map, just provide // an array here instead of a color map object colors: { black: '#000000', red: '#C51E14', green: '#1DC121', yellow: '#C7C329', blue: '#0A2FC4', magenta: '#C839C5', cyan: '#20C5C6', white: '#C7C7C7', lightBlack: '#686868', lightRed: '#FD6F6B', lightGreen: '#67F86F', lightYellow: '#FFFA72', lightBlue: '#6A76FB', lightMagenta: '#FD7CFC', lightCyan: '#68FDFE', lightWhite: '#FFFFFF', }, // the shell to run when spawning a new session (i.e. /usr/local/bin/fish) // if left empty, your system's login shell will be used by default // // Windows // - Make sure to use a full path if the binary name doesn't work // - Remove `--login` in shellArgs // // Bash on Windows // - Example: `C:\\Windows\\System32\\bash.exe` // // PowerShell on Windows // - Example: `C:\\WINDOWS\\System32\\WindowsPowerShell\\v1.0\\powershell.exe` shell: '', // for setting shell arguments (i.e. for using interactive shellArgs: `['-i']`) // by default `['--login']` will be used shellArgs: ['-i'], // for environment variables env: {}, // set to `false` for no bell bell: 'SOUND', // if `true` (without backticks and without quotes), selected text will automatically be copied to the clipboard copyOnSelect: false, // if `true` (without backticks and without quotes), hyper will be set as the default protocol client for SSH defaultSSHApp: true, // if `true` (without backticks and without quotes), on right click selected text will be copied or pasted if no // selection is present (`true` by default on Windows and disables the context menu feature) // quickEdit: true, // URL to custom bell // bellSoundURL: 'http://example.com/bell.mp3', // for advanced config flags please refer to https://hyper.is/#cfg }, // a list of plugins to fetch and install from npm // format: [@org/]project[#version] // examples: // `hyperpower` // `@company/project` // `project#1.0.1` plugins: ["hyper-monokai-extended", "hyper-pane"], paneNavigation: { debug: false, hotkeys: { navigation: { up: 'ctrl+alt+up', down: 'ctrl+alt+down', left: 'ctrl+alt+left', right: 'ctrl+alt+right' }, jump_prefix: 'ctrl+alt', // completed with 1-9 digits permutation_modifier: 'shift', // Added to jump and navigation hotkeys for pane permutation maximize: 'shift+ctrl+x' }, showIndicators: true, // Show pane number indicatorPrefix: '⫎⦗⌬⦘', // Will be completed with pane number indicatorStyle: { // Added to indicator

position: 'absolute', top: 0, left: 0, fontSize: '12px' }, focusOnMouseHover: false, inactivePaneOpacity: 0.6 // Set to 1 to disable inactive panes dimming }, // in development, you can create a directory under // `~/.hyper_plugins/local/` and include it here // to load it and avoid it being `npm install`ed localPlugins: [], keymaps: { // Example 'window:devtools': 'ctrl+alt+o', }, }; ```

chabou commented 5 years ago

@blakejwc your paneNavigation should be in config section (sorry for the delay).