search

chabou / hyper-pane

Extension for Hyper.app to enhance pane navigation.
MIT License
191 stars 13 forks source link

CSS fixes #40

Closed MircoT closed 5 years ago

MircoT commented 5 years ago

These changes fix the indicator visualization and add a default style to panel separators.

chabou commented 5 years ago

Thank for your help 🙏

I don't want to add style to panel separators, because I think that users who add this plugin want to enhance functionality and not design. Changing this could lead to some theme breakage. This is better to add it by yourself in your config.

Indicator position was choosing to be absolute to use padding space. The goal was to not waste some space for this and reduce term space for a given window size. The good thing is that you can change this css in plugin configuration in your .hyper.js.

I understand that your PR is really better in some cases. But I think that current defauts are better most of time.

But I can change my mind 😄

MircoT commented 5 years ago

@chabou, I understood. I changed the indicator position because in my view it goes on the background and the new terminal panel overlaps over it. The separator style could be useful but of course, depends on the user taste.

For the moment I close the PR. Thanks for the response, I just wanted to share some improvements due to working time.