Focus on mouseover not working

chabou / hyper-pane

Extension for Hyper.app to enhance pane navigation.

MIT License

188 stars 13 forks source link

Focus on mouseover not working #42

Closed chalkos closed 5 years ago

chalkos commented 5 years ago

Hi, the config config.paneNavigation.focusOnMouseHover stopped working on 3.0.0-canary.5

A warning on the console reads:

The underlying terminal engine of Hyper no longer uses iframes with individual `document` objects for each terminal instance. This method call is retained for backwards compatibility reasons. It's ok to attach directlyto the `document` object of the main `window`.
    getTermDocument @ bundle.js:1

chabou commented 5 years ago

Thank you for your feedback 🙏 I reproduced your issue.

It seems due to some breaking change with: term.termRef https://github.com/chabou/hyper-pane/blob/7f0c766c5d72bb1d294af462a50a896b5672a563/index.js#L629-L637

Old fashioned way is wrongly used

chabou commented 5 years ago

Fixed in Hyper v3.0.0-canary.6 🎉

chalkos commented 5 years ago

It is working for me too, thanks! :tada: