Doesn't work with Hyper 1.2.1

lanthaler commented 7 years ago

I just tried the plugin with Hyper 1.2.1. It breaks split panes. Here's my config:

paneNavigation: {
  debug: true,
  hotkeys: {
    navigation: {
      up: 'shift+up',
      down: 'shift+down',
      left: 'shift+left',
      right: 'shift+right'
    },
    permutation_modifier: 'ctrl', // Added to jump and navigation hotkeys for pane permutation
  },
  showIndicators: false,
  focusOnMouseHover: false
}

and here's the debug output:

(re)loading renderer plugins
index.html:34 total init time 284.67499999999995
index.js:31 |HYPER-PANE| updateChildrenFrames: call on af684550-816f-448d-ae38-60d7203c6733
index.js:31 |HYPER-PANE| updateChildrenFrames: no children found, skipping 365ef91c-1377-4709-84dc-73e9681ce29d
index.js:524 Uncaught TypeError: Cannot read property 'getTermDocument' of undefined
index.js:31 |HYPER-PANE| updateChildrenFrames: call on af684550-816f-448d-ae38-60d7203c6733
index.js:31 |HYPER-PANE| dealing child 324163d4-c576-416f-96a0-e577632a8e93
index.js:31 |HYPER-PANE| Setting frame for Object 0 0.5
index.js:31 |HYPER-PANE| updateChildrenFrames: call on 324163d4-c576-416f-96a0-e577632a8e93
index.js:31 |HYPER-PANE| updateChildrenFrames: sessionUid found, skipping 365ef91c-1377-4709-84dc-73e9681ce29d
index.js:31 |HYPER-PANE| dealing child 83f72570-eb48-483c-8f82-f77b3c255ce9
index.js:31 |HYPER-PANE| Setting frame for Object 0.5 0.5
index.js:31 |HYPER-PANE| updateChildrenFrames: call on 83f72570-eb48-483c-8f82-f77b3c255ce9
index.js:31 |HYPER-PANE| updateChildrenFrames: sessionUid found, skipping f04d4a8b-10b7-4585-bd22-30f8e5543a57
index.js:524 Uncaught TypeError: Cannot read property 'getTermDocument' of undefined
7bundle.js:39 Uncaught TypeError: Cannot read property 'getPrefs' of undefined
bundle.js:11 Uncaught TypeError: Cannot read property 'focusHyperCaret' of undefined
3bundle.js:39 Uncaught TypeError: Cannot read property 'getPrefs' of undefined

iamstarkov commented 7 years ago

did you restart the hyper?

ltegman commented 7 years ago

I've noticed this as well, but for me it only occurs if I have showIndicators set to false. If I leave it true everything works as expected.

chabou commented 7 years ago

Thank you for your feedbacks. I'll check that soon

iamstarkov commented 7 years ago

@lanthaler can you update to the latest version?

chabou commented 7 years ago

fixed by d89f68d493cfce1ea1d8da7193e2eaaba70bacf0 @ltegman thanks to have pointed me in the right direction

chabou commented 7 years ago

fix published with version v1.1.2

lanthaler commented 7 years ago

Opened #7 because this still doesn't seem to work.

chabou / hyper-pane

Doesn't work with Hyper 1.2.1 #5