chad / turbulence

Hopefully-meaningful metrics
http://chadfowler.com
MIT License
240 stars 29 forks source link

Windows platform fix #6

Closed kitofr closed 13 years ago

kitofr commented 13 years ago

Found a couple of issues and hopefully fixed em in a graceful way.

chad commented 13 years ago

Hi. Thanks for all of this work. Am I missing a file?

$ rake (in /Users/chad/src/turbulence) rake aborted! no such file to load -- win_rakefile_location_fix /Users/chad/src/turbulence/Rakefile:2:in `<top (required)>' (See full trace by running task with --trace)

kitofr commented 13 years ago

Yes you are... sorry. Apparently I must have missed that one. I just pulled in the latest and fixed some issues. Should hopefully be back on green now.

Sorry for the inconvenience.

chad commented 13 years ago

Sorry to be a bummer, but is it still missing or am I doing something wrong?

no such file to load -- win_rakefile_location_fix

Thanks, Chad

kitofr commented 13 years ago

Chad, it might be my inexperience with git/fork/pull-request but I think the file should be there. Looking at the commits above "Rakefile_location_fix" adds the file in. I added a more proper loading of that file, hopefully that solves it.

Sorry again for the inconvenience.

chad commented 13 years ago

Aha, yes! Sorry I didn't see it. Long day yesterday :) Ruby1.9.2 removes "." from the LOAD_PATH. Will get this in thank you!

kitofr commented 13 years ago

:) Maybe we/you should bump the ruby-version from 1.8.7. Might remove some of my "fixes" like absolute_path => expand_path etc.