search

chad3814 / node-hashtable

Native hashtable interface for when V8 objects can't take the heat
MIT License
106 stars 41 forks source link

Build fails on macOS Sierra #32

Open crazyquark opened 7 years ago

crazyquark commented 7 years ago

The build fails on macOS Sierra because it tries to include <tr1/unordered_map>. This was on version 2.0.2.

crazyquark commented 7 years ago

I've created a PR that fixes this: https://github.com/chad3814/node-hashtable/pull/33

leyeye commented 7 years ago

Can you tell me how to fix the issue in detail, because i don't quiet understand what is PR and how it works,thanks a lot for your kindness !

sharper commented 7 years ago

As of macOS 10.12 Sierra, the default is now libc++ and libstdc++ is deprecated. libstdc++ is quite old, v4.2.1, and predates C++11 (hence the tr1 headers). If you're going to be using this code long-term, it'd be worth the time to at least make it C++11 compliant (i.e. #include )

peterkuiper commented 7 years ago

This module can't be build on MacOS X (10.11.6) when using v8 (works fine with v6 though). We have some dependencies on hashtable so I'm hoping the package maintainer will create a new build soon...

timothystewart6 commented 6 years ago

Any update on merging and releasing this? I could use it too. It won't build on macOS.