search

chad3814 / node-hashtable

Native hashtable interface for when V8 objects can't take the heat
MIT License
106 stars 41 forks source link

Add forEach() iterator #7

Closed chad3814 closed 10 years ago

chad3814 commented 10 years ago

This adds a forEach(function (key, value) {...}) basic iterator Also return boolean true or false on remove()

ghost commented 10 years ago

I haven't been using Node lately and I don't see myself using it much in the future. Would you like to take over this project? I'll make you the maintainer on npm as well.

(the PR looks good by the way)

chad3814 commented 10 years ago

Sure, looks like we're going to use this at work.

My npm userid is chad3814, you can add me as an owner with: npm owner add chad3814 hashtable

ghost commented 10 years ago

Alright, I added you as an owner which is showing up with npm owner ls hashtable, but not npm info hashtable, so I'll wait to take myself off until you've verified you have access. Would you rather duplicate the repository you already have, or delete your fork and have me transfer ownership of the original?

chad3814 commented 10 years ago

You can transfer ownership, I've deleted my fork. I published a new version tonight, so all looks good.

ghost commented 10 years ago

I started a transfer by the way. You'll need to accept it and everything will be done. Cheers.

chad3814 commented 10 years ago

Sorry, I didn't click the link soon enough so the transfer expired, would you mind doing it again?

chad3814 commented 10 years ago

Done. Thanks.