search

chadaustin / sajson

Lightweight, extremely high-performance JSON parser for C++11
MIT License
565 stars 41 forks source link

ERROR_SUCCESS conflict with a macro from <windows.h> #40

Closed wojdyr closed 6 years ago

wojdyr commented 6 years ago

Just to let you know: when including sajson.h after I get one error: ERROR_SUCCESS is defined as a macro (0x0) in Windows headers.

iboB commented 6 years ago

Perhaps changing it to ERROR_NO_ERROR (or simply NO_ERROR) is the way to fix this. This will break backwards compatibility slightly but I guess very few users actually check for the ERROR_SUCCESS constant.

ddevienne commented 6 years ago

Also ran into that one. Unfortunate choice of name.