12 digit vatnumber validation for United Kingdom is incorrect

chadjlucas / vatnumber

Automatically exported from code.google.com/p/vatnumber

GNU General Public License v3.0

1 stars 5 forks source link

12 digit vatnumber validation for United Kingdom is incorrect #7

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
>>> import vatnumber
>>> vatnumber.check_vat_gb('242338087388')
False

This is a valid GB VAT number according to:
http://ec.europa.eu/taxation_customs/vies/viesquer.do

What is the expected output? What do you see instead?
* Expected outcome should be True

What version of the product are you using? On what operating system?
* 0.5

Please provide any additional information below.

Original issue reported on code.google.com by taqu...@gmail.com on 6 May 2010 at 11:44

GoogleCodeExporter commented 8 years ago

According to http://sima-pc.com/nif.php
Your example should not exist.
Have you the rules to validate this number?

Original comment by cedric.krier@b2ck.com on 6 May 2010 at 12:39

GoogleCodeExporter commented 8 years ago

Fix with changeset e377191ef4ae

Original comment by cedric.krier@b2ck.com on 8 May 2010 at 1:00

Changed state: Fixed

GoogleCodeExporter commented 8 years ago

By the way, on wikipedia I saw there is a new format "100 nnnn nn" with modulo 
9755.
Do you have any examples?

Original comment by cedric.krier@b2ck.com on 8 May 2010 at 1:04

GoogleCodeExporter commented 8 years ago

Sorry, no more examples.

My example above is a valid VAT number for an existing Organisation in the UK.
Please test at this site if you are unsure. It is the official vat validation 
site: http://ec.europa.eu/taxation_customs/vies/

If sima-pc.com does not have that case, then it is not updated.
You can find some good details on the uk validation here: 
http://en.wikipedia.org/wiki/Value_added_tax_identification_number

Original comment by taqu...@gmail.com on 8 May 2010 at 3:18