chadly / Geocoding.net

C# GeoCoding / Address Validation API
MIT License
444 stars 157 forks source link

Add CancellationToken to GeocodeAsync and ReverseGeocodeAsync #110

Closed dfyx closed 5 years ago

dfyx commented 5 years ago

It would be nice to be able to cancel GeocodeAsync and ReverseGeocodeAsync. As geocoding is mostly IO-bound and HttpClient already support cancellation, it should be as simple as accepting a CancellationToken and passing it to the web requests.

If you're interested I could implement that today or tomorrow.

chadly commented 5 years ago

Yes, that sounds good.

dfyx commented 5 years ago

Alright, I got some other work to do so implementing this will take a little longer.