chadly / Geocoding.net

C# GeoCoding / Address Validation API
MIT License
444 stars 157 forks source link

Geocoding.Here packages as Geocoding.Google #119

Closed DR9885 closed 5 years ago

DR9885 commented 5 years ago

Geocoding.Here packages as Geocoding.Google

Need to fix PackageId and AssemblyTitle

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <Description>Includes a model and interface for communicating with four popular Geocoding providers. Current implementations include: Google Maps, Yahoo! PlaceFinder, Bing Maps (aka Virtual Earth), and Mapquest. The API returns latitude/longitude coordinates and normalized address information. This can be used to perform address validation, real time mapping of user-entered addresses, distance calculations, and much more.</Description>
    <AssemblyTitle>Geocoding.net Google</AssemblyTitle>
    <VersionPrefix>4.0.0-beta1</VersionPrefix>
    <Authors>chadly</Authors>
    <TargetFrameworks>netstandard1.3;net46</TargetFrameworks>
    <AssemblyName>Geocoding.Here</AssemblyName>
    <PackageId>Geocoding.Google</PackageId>
    <PackageTags>geocoding;geocode;geocoder;maps;address;validation;normalization;google-maps;bing-maps;yahoo-placefinder;mapquest</PackageTags>
    <PackageReleaseNotes>https://github.com/chadly/Geocoding.net/releases/latest</PackageReleaseNotes>
    <PackageProjectUrl>https://github.com/chadly/Geocoding.net</PackageProjectUrl>
    <PackageLicenseUrl>https://github.com/chadly/Geocoding.net/blob/master/LICENSE</PackageLicenseUrl>
    <Version>4.0.0</Version>
    <RepositoryUrl>https://github.com/chadly/Geocoding.net.git</RepositoryUrl>
    <RepositoryType>git</RepositoryType>
  </PropertyGroup>

  <ItemGroup>
    <ProjectReference Include="..\Geocoding.Core\Geocoding.Core.csproj" />
  </ItemGroup>

  <ItemGroup>
    <PackageReference Include="Newtonsoft.Json" Version="9.0.1" />
  </ItemGroup>

  <ItemGroup Condition="'$(TargetFramework)'=='netstandard1.3'">
    <PackageReference Include="System.Net.Http" Version="4.3.1" />
    <PackageReference Include="System.Runtime.Serialization.Json" Version="4.3.0" />
  </ItemGroup>

  <ItemGroup Condition="'$(TargetFramework)'=='net46'">
    <Reference Include="System.Net.Http" />
  </ItemGroup>

</Project>
DR9885 commented 5 years ago

Opened PR https://github.com/chadly/Geocoding.net/pull/120

wvansl commented 5 years ago

I need this fix, is there any other way to install the HERE parser? the Install-Package Geocoding.Here doesnt work because of this...

DR9885 commented 5 years ago

I ended up forking the project and maintaining private nuget packages, maybe try that for now, until they accept the PR

chadly commented 5 years ago

Fixed in #120