search

chadly / react-bs-notifier

A react component to show growl-like notifications using bootstrap alerts
https://chadly.github.io/react-bs-notifier/
MIT License
111 stars 26 forks source link

Ability to add Style for AlertLists #54

Open KimberlyYang opened 5 years ago

KimberlyYang commented 5 years ago

Hi! First of thanks for a great Library.

My query is about adding extra styles for the "Type" of alerts in the AlertList component With the new Bootstrap 4 We have 3 extra types ..

The current Implementation Limits the AlertList types to

if a style property was added to the type this could be remedied and would allow for Expansion of the layout types in a Generic way..

I can se that react-jss is already a dependency for "Themed Alert" that could be used in the List as a style parameter.. or if that is to much could we allow the component className to parse through from unknown type instead of undefined this would at leaste allow for css stryling?

chadly commented 5 years ago

We implement it using jss so that the styles can be overridden. To fix your issue, we would need to add secondary, light, & dark to styles.js.

I'd be happy to review a PR.