Closed GoogleCodeExporter closed 9 years ago
Hey Alec, can you send me an email with more detail on what you would like
here. I'm not sure I understand it completely.
Original comment by chadopp@gmail.com
on 20 Oct 2010 at 1:52
I've been looking at this myself today (slow day at work) and I think I need to
understand your code more before I attempt anything.
When you record, or schedule to record, any episode in MythTV a line is put in
the "oldrecorded" AND the "recorded" tables with its specific status
- If you remove the scheduled recording before it occurs, then each line on
each table is removed.
- If the episode is recorded and subsequently deleted (not "Delete and
Rerecord") the "recorded" table entry is removed but the "oldrecorded" table
entry is kept
- If the episode is recorded and then deleted with "Delete and Rerecord" then
both entries in the "recorded" and "oldrecorded" tables are removed
This is how MythTV works out not to re-record previously recorded episodes,
unless you tell it to by selecting "Delete and Rerecord".
Currently the state of each episode can either be "Not Recorded", "Previously
Recorded" or "Scheduled to Record". What I am proposing is that the "Previously
Recorded" state is limited to "Deleted" (not "Delete and Rerecord") episodes by
only checking the "oldrecorded" table (which it currently does) and an extra
state is introduced "Current Recording", or "Available to Watch" is probably
better, which only uses the "recorded" table, ignoring "Deleted" episodes.
My last bit was just make the text "Available to Watch" a hyper-link to that
recorded episode.
Does that help? I will continue to see if I can work out your code and
hopefully come up with a solution myself.
Original comment by alec.chr...@gmail.com
on 20 Oct 2010 at 1:57
Right, I think I have got the majority of it working (slight tweaks to cell
background colours) but not the hyper-links - i'm still figuring out how
MythWeb defines it links.
If you want to apply my other patch I will create a new one for this and you
can try it.
Original comment by alec.chr...@gmail.com
on 20 Oct 2010 at 8:37
I have applied the other patch..Thanks...I look forward to your patch for this.
Original comment by chadopp@gmail.com
on 21 Oct 2010 at 1:16
Original comment by chadopp@gmail.com
on 21 Oct 2010 at 3:14
Patch attached for main suggestion. I still haven't figured out the hyper-link
bit, so mark this issue as resolved and I will create a new one just for
hyper-links.
Original comment by alec.chr...@gmail.com
on 21 Oct 2010 at 7:28
Attachments:
On a side note, what does "episode/episodes/?allEpisodes=all" do? I can only
see one reference to it and that doesn't really do much...?
Original comment by alec.chr...@gmail.com
on 21 Oct 2010 at 3:21
Alec...Very nice addition. I really like what you have done. I do think
though that there is not a distinct enough difference between the color of the
previously recorded and the not recorded episodes. I like the dash lines but I
think the background between the 2 needs to be different so a quick look will
be very easy to recognize what hasn't been recorded. Overall though very nice
addition. The allEpisodes is used on the episodes page to display all episodes
of the current show.
Original comment by chadopp@gmail.com
on 22 Oct 2010 at 2:16
Original comment by chadopp@gmail.com
on 22 Oct 2010 at 2:46
The episodesall is used for navigating on the episodes page. You can click on
the recorded, not recorded, scheduled, or all episodes links.
Original comment by chadopp@gmail.com
on 22 Oct 2010 at 2:57
I agree, having looked at it again this morning it is too similar. I have
adjusted to show brown background instead for Previous Recordings, and also
removed the dotted line around the Not Recorded as not really needed.
Patch attached.
Original comment by alec.chr...@gmail.com
on 22 Oct 2010 at 7:44
Attachments:
Made a few changes to the colors. I was thinking that we could make the colors
a configuration option for the user to choose.
Original comment by chadopp@gmail.com
on 23 Oct 2010 at 5:07
Yeah, put it in a handler.php or something, that's a good idea.
Original comment by alec.chr...@gmail.com
on 23 Oct 2010 at 7:11
I was originally thinking the handler.php because that would be the quickest,
however I'm thinking we might should put it under data/episode some place so
that an upgrade of mythepisode doesn't require the user to reconfigure user
specific options. There are a couple of things in handler.php that should
probably be relocated. i.e. matchPercent. I will write a ticket.
Original comment by chadopp@gmail.com
on 23 Oct 2010 at 2:44
Original issue reported on code.google.com by
alec.chr...@gmail.com
on 19 Oct 2010 at 11:51