search

chadopp / mythepisode

TV Series/Shows
2 stars 3 forks source link

Summary at top of Episodes says 1 Scheduled, but none listed #16

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Needs my dataset

What is the expected output? What do you see instead?
I expect to see either: one of the lines highlighted as "Scheduled to Record" 
or (as none have matched) the summary say "Scheduled: 0"

What version of the product are you using? On what operating system?
mythtv+web .23 mythepisode 1.0.6

Please provide any additional information below.
The summary has correctly identified that there is a future recording, but with 
a slightly different sub-title ("Nicky" instead of "Nicholla") - I will be 
getting the information in TV rage updated to match as its EIT info I have.

If the "Scheduled: x" summary is to be used as an aid to show which episodes 
are incorrect in TVRage, then maybe we need an extra column for "Scheduled but 
unmatched: x"?

Original issue reported on code.google.com by alec.chr...@gmail.com on 20 Oct 2010 at 8:17

GoogleCodeExporter commented 9 years ago 
I have just noticed this on other Seasons. It looks like the "Scheduled" 
summary value is being taken from the scheduled table, but not ignoring 
"Duplicate" or "Never Record" schedules. I will look further in to how the 
summary info is obtained.

Original comment by alec.chr...@gmail.com on 20 Oct 2010 at 2:01

GoogleCodeExporter commented 9 years ago 
I have seen similar issues in this area.  For instance "World of Jenks" first 
episode aired on 9/12/2010.  Some of the episodes that I have scheduled for 
recording in mythtv have an original airdate of 9/12/2010 even though it is a 
new episode and is scheduled to air sometime after that date.  As a result on 
the episode page for that show it may show 3 episodes scheduled to record but 
have the original episode aired on 9/12/2010 highlighted for recording.  This 
only happens on shows that don't have distinct subtitles since mythepisode 
attempts to match subtitles first.  However, when the show is finally recorded 
it will show up properly for the episode as being recorded because the record 
date and original airdate from tvrage will match.  I'm not sure how to go about 
fixing this one.  If you have any ideas or code updates send them my way.

Original comment by chadopp@gmail.com on 21 Oct 2010 at 1:27

GoogleCodeExporter commented 9 years ago 
I am having this problem when the tvrage data stored on my computer isn't up to 
date.  If I check the upcoming recordings, I see the show is being recorded x 
times.  The counter is correct, however, no episodes are being displayed.  If I 
press the "Update Episode Listing" link, then things are displaying correctly.

With that, here is a patch that will auto update the data on the local 
computer.  This change will force the update on the data, if there is no "INFO" 
(really old file) or if the show is a current show (no end date) and the last 
modified date is older than 7 days.

Original comment by chris.k...@gmail.com on 24 Oct 2010 at 12:01

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for the patch Chris.  This is something I had given some thought to a 
while back.  I think I would like to make the 7 days configurable in 
handler.php for now and eventually in our configuration file in data/episode 
someplace.  

This problem can occur for several reasons.
1.  Local data is not up to date from tvrage.  Your patch fixes this.
2.  Data for show doesn't exist in tvrage.  i.e. My wife just started watching 
this new show called "The Talk" which tvrage currently has no data for.  As a 
result when you navigate to that show you will see several episodes 
recorded/scheduled but no episodes listed.  Not sure that we can fix this one.  
Alec suggested we could add something saying like scheduled but not matched.  
Another option would be to grab data from another source like TheTVDB.com which 
I think we need to look at anyway.  If tvrage decides they want to stop 
providing listings then we are out of business for a while.  It would be nice 
to have several sources for data.
3.  Invalid information in the mythtv listing.  Like all new episodes of "World 
of Jenks" being set with an original airdate of 9/12/2010.  I believe 
"Survivor" does the same thing.  After the show is recorded it shows properly 
on the episode page because of the record date.  This one is difficult to 
overcome since we don't control the data that comes from the scheduler.
4.  Invalid data coming from tvrage.  The data is only as good as the people 
that enter it.  with tvrage you can let them know when something is incorrect 
and they will usually fix it fairly quick.

Original comment by chadopp@gmail.com on 24 Oct 2010 at 7:07

GoogleCodeExporter commented 9 years ago 
Although I haven't tried your patch, I tried pressing the "Update Episode 
Listing" and this did not solve my issue, because all but one of the episodes 
are recorded with nothing in my "Upcoming Recordings" as "Will Record", yet I 
am still getting a "Scheduled: 2" at the top.

I agree that the data should be updated automatically if its old, but maybe its 
better to do this with a weekly cron job rather than as a user browses the 
pages?

Looking further into it, I do have 2 "Upcoming Recordings" of the show that 
"Will Never Record" - maybe that's what the summary should be ignoring?

Original comment by alec.chr...@gmail.com on 24 Oct 2010 at 7:10

GoogleCodeExporter commented 9 years ago 
Alec...You can add a print statement in episode.php like this to see what it is 
seeing.
It's around line 142.
                        continue;
                    }
print "Sched Episode is $show->subtitle - at $show->airdate<BR>";
                    // Assign a reference for this show to the various arrays
                    $schedDate[]     = $show->airdate;

Original comment by chadopp@gmail.com on 24 Oct 2010 at 7:41

GoogleCodeExporter commented 9 years ago 
Ah ok, I also added the $show->recstatus variable and it seems to forget 
"NeverRecord" episodes. Patch attached.

Original comment by alec.chr...@gmail.com on 24 Oct 2010 at 8:13

Attachments:

GoogleCodeExporter commented 9 years ago 
what happens if you add NeverRecord around this section of the code in 
episode.php

like this

                    // Skip duplicate shows?
                        elseif (in_array($show->recstatus, array(
                        'DontRecord',
                        'NeverRecord',
                        'PreviousRecording',
                        'CurrentRecording',
                        'EarlierShowing',
                        'LaterShowing'

Original comment by chadopp@gmail.com on 24 Oct 2010 at 8:14

GoogleCodeExporter commented 9 years ago 
Cool...looks like we had the same thought....bed time.

Original comment by chadopp@gmail.com on 24 Oct 2010 at 8:15

GoogleCodeExporter commented 9 years ago 
Alec, I thought about a cron job to perform the update.  However, I decided 
against it.  My main reason against this is, I didn't want to overwhelm the 
free services with 100's or 1000's of requests per person per week.  With this 
approach, we are only grabbing the data the user is interested in seeing at the 
time they are wanting it.  For me the data is retrieved quickly.

Original comment by chris.k...@gmail.com on 24 Oct 2010 at 10:30

GoogleCodeExporter commented 9 years ago 
Chad.. Here is an update to the patch.  I have included your suggestion of 
allowing the value to be configurable in the handler.php.

Original comment by chris.k...@gmail.com on 24 Oct 2010 at 1:30

Attachments:

GoogleCodeExporter commented 9 years ago 
Chris you are right about the grabbing of data.  Both tvrage and thetvdb terms 
of service ask that the code for ones project be written in such a way that 
users only get the data that they need and not try to grab everything.  When I 
first wrote mythepisode and was providing the data files with the download it 
was for this reason.  I had already at the time downloaded everything and 
didn't want others to have to do the same.  And as you know summary.pl was much 
slower and much more cpu intensive.  With the update to grabbing of episode 
information because of the API key the download is much faster.  

Alec...should I close this one?  Do you consider the original problem 
corrected?  Do we need to close and open a new ticket.

Original comment by chadopp@gmail.com on 24 Oct 2010 at 4:09

GoogleCodeExporter commented 9 years ago 
Chad, 
I've attempted to handle the situation where we have more episodes then tvrage. 
 For example, in 90210, TVRage has only one upcoming episode.  However, the 
upcoming recordings is showing the next two.

Original comment by chris.k...@gmail.com on 24 Oct 2010 at 9:31

Attachments:

GoogleCodeExporter commented 9 years ago 
Chad.  I noticed the patch incorporated some changes in regards to the hide 
tvwish stuff.  This version doesn't include those.

Original comment by chris.k...@gmail.com on 24 Oct 2010 at 10:26

Attachments:

GoogleCodeExporter commented 9 years ago 
That's ok Chris...I was able to work around that.  It was giving me a few 
issues at first, but I have both pieces implemented.  I was thinking we should 
change the color of the scheduled to record but not matched to some slight 
variation of the shade used for the scheduled to record just to be able to 
distinguish quickly the diffs. what do you think?

Original comment by chadopp@gmail.com on 24 Oct 2010 at 10:49

GoogleCodeExporter commented 9 years ago 
I forgot to mention...nice patch as usual

Original comment by chadopp@gmail.com on 24 Oct 2010 at 11:33

GoogleCodeExporter commented 9 years ago 
I like that idea Chad.   
How about, if we do the following add $classes = " record_duplicate scheduled"; 
to tmpl/default/episodes.php (line 386) as in below:

$_SESSION['episodes']['allepisodes'] = "all";
$classes = " record_duplicate scheduled";
        foreach ($schedEpisodesDetails as $Log) {
            if (!$Log["matched"]) {

Original comment by chris.k...@gmail.com on 24 Oct 2010 at 11:47

GoogleCodeExporter commented 9 years ago 
Looks good...I think we will have a nice release with all the patches you and 
Alec have added recently.  Thanks

Original comment by chadopp@gmail.com on 25 Oct 2010 at 12:00

GoogleCodeExporter commented 9 years ago 
@ comment 12: I believe one half of the issue is sorted, but I'm not sure its 
completely sorted - I tested a few other series that I have and I still get 
some with "Scheduled: x" but not highlighted. Looking further in to it, these 
episodes ARE scheduled to record at the correct dates, but they have different 
sub-titles. It would seem that the date matching isn't working correctly? I've 
not had time to track down if its been caused by recent updates or not, I will 
look later.

Original comment by alec.chr...@gmail.com on 25 Oct 2010 at 8:59

GoogleCodeExporter commented 9 years ago 
Chad and Alec.. I noticed in one show that is in high syndication that the 
scheduled to record said 22.  However, it was set to only record 2. (lots of 
duplicates and previously recorded)  This is also causing some issues with the 
new code I submitted in comment 12 and 13.  I will review the code and see if I 
can clean up the "unmatched and scheduled to record".  However, I'm not sure 
whether we should be changing the counter.

Original comment by chris.k...@gmail.com on 25 Oct 2010 at 10:24

GoogleCodeExporter commented 9 years ago 
Chad and Alec,
I believe I have corrected the extra "unmatched and scheduled to record" 
entries.  Please let me know what you think.

Original comment by chris.k...@gmail.com on 25 Oct 2010 at 11:10

Attachments:

GoogleCodeExporter commented 9 years ago 
so far so good...Do you think we should decrement the scheduled to record 
number?  I could probably go either way on this.

Original comment by chadopp@gmail.com on 26 Oct 2010 at 2:15

GoogleCodeExporter commented 9 years ago 
Chad.. I'm not sure what to do with the issue of scheduled to record number 
when the duplicates and previously recorded are affecting the number.

Original comment by chris.k...@gmail.com on 26 Oct 2010 at 12:20

GoogleCodeExporter commented 9 years ago 
I think we can leave it as is for now.  It's much improved.

Original comment by chadopp@gmail.com on 27 Oct 2010 at 2:08

GoogleCodeExporter commented 9 years ago

Original comment by chadopp@gmail.com on 7 Nov 2010 at 7:11