chadopp / mythepisode

TV Series/Shows
2 stars 3 forks source link

Fix episode deletion #23

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I have temporarily commented out the episode deletion functions from both 
episode.php files.  It is commented.  I did this because I'm not sure if I was 
deleting the episode from all of the appropriate tables.  I'm only deleting 
from the oldrecorded table and may need to also delete from the recorded table. 
 I haven't had time to look at it so someone is welcome to take a look.  It 
could be correct as is but needs to be verified.

Original issue reported on code.google.com by chadopp@gmail.com on 22 Oct 2010 at 2:31

GoogleCodeExporter commented 9 years ago
I also commented out the deletes in previous_recordings.php.

Original comment by chadopp@gmail.com on 22 Oct 2010 at 2:35

GoogleCodeExporter commented 9 years ago
I believe this works as it should.  Needs some further testing.  Updates are in 
trunk

Original comment by chadopp@gmail.com on 23 Oct 2010 at 5:06

GoogleCodeExporter commented 9 years ago
I'm sure what the goal is for this feature, now that we can see which 
recordings are Previous, Watched and Unwatched do you want to be able to delete 
the Watched/Unwatched recording? If so you're better off doing it through the 
TV module

Or do you want to just remove the notification that something has been 
Previously Recorded?

Original comment by alec.chr...@gmail.com on 23 Oct 2010 at 3:00

GoogleCodeExporter commented 9 years ago
The purpose of this was to be able to delete from the DB something that doesn't 
currently exist in the recorded table.  I want to remove something that is 
previously recorded so that I can record it again or for some reason it got 
deleted from the recorded table before I was able to see it, etc.  I know this 
can be done from the frontend, but I wanted to be able to do it from within 
mythweb.

Original comment by chadopp@gmail.com on 23 Oct 2010 at 4:03

GoogleCodeExporter commented 9 years ago

Original comment by chadopp@gmail.com on 25 Oct 2010 at 1:30

GoogleCodeExporter commented 9 years ago
All seems pretty logical so I decided to try it out :) A couple of funnies:

- The re-loaded with the previous show I was looking at, not the one I deleted 
a show from
- If you use this to delete a show that is "Watched" or "Unwatched" then it has 
no effect... as well as deleting from the "oldrecorded" table, you will need to 
command deletion of the "recorded" table entry AND also delete the actual file 
- might want to look into the mythweb/tv module's way of doing it?

Original comment by alec.chr...@gmail.com on 25 Oct 2010 at 2:15

GoogleCodeExporter commented 9 years ago
Alec...will you elaborate on your first bullet as I'm unable to reproduce it.  
I agree with your second bullet.  I hadn't given any thought to shows that 
still exist in the recorded programs tab.  My original thought was to be able 
to delete shows from the DB that no longer exist.  I will take a look at this.

Original comment by chadopp@gmail.com on 26 Oct 2010 at 2:28

GoogleCodeExporter commented 9 years ago
Fixed bullet #2 and an error in previous_recordings.php

Original comment by chadopp@gmail.com on 26 Oct 2010 at 4:19

GoogleCodeExporter commented 9 years ago
Bullet 1: Let me walk through an example:
1) Click on "American Idol" in Shows List
2) Click back on "TV Episodes" Menu link
3) Click on "The Big Bang Theory" in Shows List
4) Click on "Recorded" sub-menu link
5) Click on "Delete" of an episode
6) Page refreshes back to "American Idol"

On a new side note, I have noticed that the previous items I deleted no longer 
appear in this list, but because we are now also looking at the "recorded" 
table they are being matched - I will open a new ticket to update this page.

Original comment by alec.chr...@gmail.com on 26 Oct 2010 at 7:25

GoogleCodeExporter commented 9 years ago
Alec...what browser are you using.  I'm using google chrome and haven't been 
able to reproduce this.  Chris have you tested this?

Original comment by chadopp@gmail.com on 27 Oct 2010 at 2:13

GoogleCodeExporter commented 9 years ago
Hmmm, I tried it again and it didn't happen - not sure what's going on there. 
Apologies.

Original comment by alec.chr...@gmail.com on 27 Oct 2010 at 7:08

GoogleCodeExporter commented 9 years ago

Original comment by chadopp@gmail.com on 28 Oct 2010 at 2:16

GoogleCodeExporter commented 9 years ago

Original comment by chadopp@gmail.com on 21 Nov 2010 at 3:33