chadopp / mythepisode

TV Series/Shows
2 stars 3 forks source link

shows.php - Differentiation between UK and US recorded shows #27

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Go to Main Page having recorded an episode of UK series Masterchef or Top 
Gear or X-Factor
2.
3.

What is the expected output? What do you see instead?
"Masterchef (UK)" displayed in the the list of recorded shows. However, only 
"Masterchef (US)" is shown.

What version of the product are you using? On what operating system?
mythtv+web 0.23-fixes, mythepisode 1.0.7

Please provide any additional information below.
The correct version, (UK or US or both if both are recorded) in the shows list. 
I've not looked at how the shows part works yet - maybe someone can shed some 
light?

Original issue reported on code.google.com by alec.chr...@gmail.com on 22 Oct 2010 at 11:58

GoogleCodeExporter commented 9 years ago
I will take a look at this one.  When I originally wrote this I wrote with the 
thought that one would only be selecting one country.  However, I now know from 
several people that sometimes several countries are selected.  I might need 
some additional input from you, but I will let you know.

Original comment by chadopp@gmail.com on 23 Oct 2010 at 1:34

GoogleCodeExporter commented 9 years ago
I'm still looking at this one.  The first problem is how I'm laying shows out 
in the shows.txt file.  The 2nd column is being stripped of the country code 
which is causing a problem when we serialize the shows.dat file.

shows.txt
hellskitchenuk  Hell's Kitchen     Hell's Kitchen (UK)     1
hellskitchenus  Hell's Kitchen     Hell's Kitchen (US)     1

Column 2 is the key being used during the creation of shows.dat which means 
only the first entry is being added to shows.dat and the next one skipped.  
Changing this will cause some other issues that I will have to sort out.

Original comment by chadopp@gmail.com on 23 Oct 2010 at 4:09

GoogleCodeExporter commented 9 years ago
I think I can change the explodeShows function to overcome my comment from 
above.

Original comment by chadopp@gmail.com on 23 Oct 2010 at 4:21

GoogleCodeExporter commented 9 years ago
Alec..Do you have shows where you record both the US version and the UK 
version. i.e. would you ever record MasterChef (UK) and MasterChef (US).  If so 
is there any think in the recorded programs listing that indicates what country 
the episode is recorded from.  Currently only having access to shows in the US 
if I record MasterChef it would not have any indications that it was a US 
episode.  i.e. it wouldn't say MasterChef (US) in the recorded program list.  
I'm just trying to determine how we might determine that a show was recorded in 
the UK versus US and display the appropriate episode recording stats in 
mythepisode under the appropriate country.

Original comment by chadopp@gmail.com on 24 Oct 2010 at 7:02

GoogleCodeExporter commented 9 years ago
I have a way around the issue you are having.  The only caveat is that if you 
record something like MasterChef for both US and UK there will be a problem.  
It's not a new problem with this fix, but one half of the problem that this 
doesn't fix.  Try this.

In show.php change this line
        $recordedShows[fixShow($show[1])] = $show;
to
        $recordedShows[fixShow($show[2])] = $show;

Now add the shows that you are having issues with to override.txt
MasterChef:::MasterChef (UK)
Wipeout:::Wipeout (US)
Hell's Kitchen:::Hell's Kitchen (US)
Big Brother:::Big Brother (US)

and any others that might impact you.

on the main mythepisode page do an "Update Show Listing"

Original comment by chadopp@gmail.com on 25 Oct 2010 at 12:17

GoogleCodeExporter commented 9 years ago
Hmmm, no I dont actually have any recorded for both countries.

As you say, your suggestion works with the caveat, but I will try and get some 
recordings of US AND UK shows of the same name to try and see what we can do to 
properly fix it.

Original comment by alec.chr...@gmail.com on 25 Oct 2010 at 9:36