chadopp / mythepisode

TV Series/Shows
2 stars 3 forks source link

Recorded shows not showing up in the recorded section of show.php #36

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. shows such as Hawaii Five-0 do not show up in the recorded section until you 
add at it to the override.txt

What is the expected output? What do you see instead?
I would expect to see the show on the recorded tab.

What version of the product are you using? On what operating system?
trunk

Please provide any additional information below.
I was thinking it would be nice to be able to see these shows, in possibly red. 
 This would then highlight to the user that these recorded shows aren't matched 
to tvrage.com and they may need to add an entry into override.txt

Original issue reported on code.google.com by chris.k...@gmail.com on 31 Oct 2010 at 7:36

GoogleCodeExporter commented 9 years ago
Yeah this is a tough one because of the matching used with shows.dat.  It looks 
for an exact match to display it on the recorded shows page.  I'm sure we can 
overcome this though with a little thought.  I will probably put out 1.0.7 next 
weekend since we have a bunch of new stuff.  If you guys are working on 
something let me know and I can delay it if necessary.

Original comment by chadopp@gmail.com on 31 Oct 2010 at 8:30

GoogleCodeExporter commented 9 years ago
I have an idea.  I'm going to create a override edit screen in the settings 
section.  There it will allow you to edit those that aren't matched and to 
match them.  This still won't solve the problem, however, it will certainly 
make it a lot easier to find the unmatched shows and create the override record.

I'm not sure when I will have this done though, so please don't hold up your 
release for this.

Original comment by chris.k...@gmail.com on 31 Oct 2010 at 9:18

GoogleCodeExporter commented 9 years ago
I think at some point we should also add things like country.txt and any other 
option we might find useful.

Original comment by chadopp@gmail.com on 31 Oct 2010 at 10:22

GoogleCodeExporter commented 9 years ago
Good idea Chris...keep in mind shows like Survivor that can have a new
name each season.  They are handled in override.txt like this
Survivor: Nicaragua---Survivor: Pearl Island:::Survivor

Survivor: Nicaragua is a season
Survivor: Pearl Island is a season
Survivor is the name in mythepisode

Notice each season name is separated by ---

Original comment by chadopp@gmail.com on 31 Oct 2010 at 10:35

GoogleCodeExporter commented 9 years ago
Thank you.  I wasn`t aware of that.  If you would like to see a working  
earlier version of what I am thinking about.  It has the current overrides at 
the top and the ones that may need an override below.  Movies aren`t part of 
the list.  The second set_override.php belongs in the tmpl directory.

Original comment by chris.k...@gmail.com on 1 Nov 2010 at 1:03

Attachments:

GoogleCodeExporter commented 9 years ago
That's real nice Chris.  Now if we can figure out how to integrate shows like 
Survivor.  

Original comment by chadopp@gmail.com on 1 Nov 2010 at 2:33

GoogleCodeExporter commented 9 years ago
I'm looking at my original code and we may be able to just put them on a 
separate line as if they were different shows.

Survivor: Nicaragua        Survivor
Surviver: Pearl Island     Survivor

61st Primetime Emmy Awards    The Emmy Awards
62nd Primetime Emmy Awards    The Emmy Awards

I can't test this as I don't have 2 shows that fit this condition right now 
since I rebuilt my system last year and blew away the DB.

Original comment by chadopp@gmail.com on 1 Nov 2010 at 2:47

GoogleCodeExporter commented 9 years ago
Above was how it would display in your setting display.  Below is how it would 
go into
override.txt.  This might work...not sure though 

Survivor: Nicaragua:::Survivor
Surviver: Pearl Island:::Survivor
61st Primetime Emmy Awards:::The Emmy Awards
62nd Primetime Emmy Awards:::The Emmy Awards

Original comment by chadopp@gmail.com on 1 Nov 2010 at 3:05

GoogleCodeExporter commented 9 years ago
Chris,

Is the delete checkbox working for you?  I'm thinking maybe we should add a 
blank entry widget at the bottom of the list so one can type in a completely 
new entry that doesn't show up in the list.  What do you think?  I updated 
trunk with your code.  I was thinking about tackling this one a few days ago.  
I'm glad you got to it first.

Original comment by chadopp@gmail.com on 1 Nov 2010 at 4:43

GoogleCodeExporter commented 9 years ago

Original comment by chadopp@gmail.com on 1 Nov 2010 at 5:12

GoogleCodeExporter commented 9 years ago
Thanks Chad.  It wasn't as tough as I originally thought.

No the delete isn't working, I haven't added any code for that.  I wasn't sure 
what I was going to do here.  Blanking the tvrage value will "delete" the line. 

I have several seasons of Survivor and Amazing race listed in my oldrecorded 
database.  If you enter those shows into the override.txt, they will display, 
even if they aren't in your oldrecorded database.  (For a while I had the 
Survivor - heroes and villains in there twice and couldn't figure out why until 
I found a spelling mistake)  They will display one after another, to make it 
easier to read/edit.  However, these shows are currently duplicated in the 
list.  Once at the top with a tvrage value and once below.  The program is 
editing/saving these correctly.  If we went to one show per line in the file, 
it would make it easier to eliminate the duplicate.  

The blank line is a good idea.  The only problem I see with that is, how do we 
give them another blank line, when they have keyed one in.

Original comment by chris.k...@gmail.com on 1 Nov 2010 at 10:44

GoogleCodeExporter commented 9 years ago
If one line per show works fine then we should probably do that.  Do you get 
the episodes listed properly under the show.  i.e. For survivor if you list 
each season on a separate line and then navigate to survivor do all of the 
episodes list properly as recorded/not recorded, etc.  

For the blank line I figured when they filled it in with something and hit save 
when the form returned the new data would now exist on its own line and a new 
blank line would appear.

Original comment by chadopp@gmail.com on 1 Nov 2010 at 2:37

GoogleCodeExporter commented 9 years ago
Chad,
The one show per line in the file doesn't work without changing other code.  
I'm fine with the way it is working with the file.  I'm displaying it as one 
show per line in the editing screen, but combining it the way you have it in 
the file.  I've included a patch that will correct the survivor showing up in 
both spots.  For me, this is working as expected.  I still have to look at the 
delete, which I am hoping to do tomorrow.

My display is showing the:
Survivor : China:               Survivor
Survivor : Gabon:               Survivor

But in the file it is:
Survivor : China---Survivor : Gabon:::Survivor

Original comment by chris.k...@gmail.com on 2 Nov 2010 at 12:45

Attachments:

GoogleCodeExporter commented 9 years ago
thanks Chris...looks good.

Original comment by chadopp@gmail.com on 2 Nov 2010 at 2:29

GoogleCodeExporter commented 9 years ago
Here's the patch that enables the delete option.  I've also filtered the old 
recorded shows by recstatus = -2 or -3 as well.  

Original comment by chris.k...@gmail.com on 2 Nov 2010 at 11:36

Attachments:

GoogleCodeExporter commented 9 years ago
thanks Chris...I think we will have a nice release with many fixes and 
enhancements.  I will probably put 1.0.7 out Friday or Saturday.  If you have 
anything else let me know.  Thanks for all the great work guys.

Original comment by chadopp@gmail.com on 3 Nov 2010 at 2:34

GoogleCodeExporter commented 9 years ago
Chris, I had to make a few changes to set_override.php because of issues with 
an initial install.  One of my tests is to delete data/episode dir as if I were 
a new user and click on things.  This worked fine if I first selected "TV 
Episodes" since all directories and files would be created if they didn't exit. 
 If my first action as a new user was to select the configuration menu then I 
would get numerous errors since shows.dat didn't exist.  I removed most of the 
shows.dat code from set_override and put a check for the shows.dat file.  If it 
doesn't exist the user is instructed to select "TV Episodes" for the first time 
and then return to configuration options.  I did this because I didn't want to 
have to put a bunch of duplicate code from shows.php into set_override.php.  
This only occurs for a new user if their first action is to select 
configuration.  I think we may need to look at creating some include files down 
the road so modules can share subroutines, etc.

Original comment by chadopp@gmail.com on 3 Nov 2010 at 4:29

GoogleCodeExporter commented 9 years ago
nice catch Chad.  Thank you.

Original comment by chris.k...@gmail.com on 3 Nov 2010 at 10:42