chadopp / mythepisode

TV Series/Shows
2 stars 3 forks source link

typo in php causes javascript errors #47

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Fresh install of 1.0.10 or from source
2. View the 'welcome' screen in mythweb
3. mouse over the 'modules' - ie, TV, Episodes, Videos, Settings, etc

What is the expected output? What do you see instead?

Expected:  'modules' hilight & unhilight appropriately, welcome text shown for 
current module
Actual: The top one works fine, but the typo in the episodes PHP causes 
Episodes and all below to not work - 
highlighting "sticks", welcome text not shown

What version of the product are you using? On what operating system?

1.0.10, SVN head, Mythbuntu 11.04.

The issue is in tmpl/default/welcome.php - it attempts to call 
'Modules::getModuleProperity'  instead of 'Modules::getModuleProperty' in two 
places.   This causes the page generation to fail.

Please provide any additional information below.

The following svn diff shows the fix:

Index: welcome.php
===================================================================
--- welcome.php (revision 424)
+++ welcome.php (working copy)
@@ -19,8 +19,8 @@

 // Next, print a list of possible subsectons
         '<ul>';
-    foreach (Modules::getModuleProperity('episode', 'links') as $link => 
$name) {
-        echo ' <li><a href="', root_url, 
Modules::getModuleProperity('episode', 'path'), '/', $link, '">', 
html_entities($name), "</a></li>\n";
+    foreach (Modules::getModuleProperty('episode', 'links') as $link => $name) 
{
+        echo ' <li><a href="', root_url, Modules::getModuleProperty('episode', 
'path'), '/', $link, '">', html_entities($name), "</a></li>\n";
     }
     echo '</ul>',

Original issue reported on code.google.com by slip...@gmail.com on 13 Dec 2011 at 3:45

GoogleCodeExporter commented 9 years ago
What version of MythTV are you using?  It looks like the developers fixed a 
typo in mythweb/classes/Modules.php at some point in a newer release of 
mythweb.  The older versions have the typo which is why my welcome.php worked.  
Thanks for the input and patch.  I will add it to the next release of 
mythepisode, whenever that might be.  I've been a little busy lately, but 
patches and enhancements are welcome.

Original comment by chadopp@gmail.com on 14 Dec 2011 at 1:15

GoogleCodeExporter commented 9 years ago
Its 0.24-fixes, relatively current but the issue has been going on for a while 
- it appears it was fixed on head and 0.24-fixes branch on September 12 2010.

Original comment by slip...@gmail.com on 14 Dec 2011 at 1:50

GoogleCodeExporter commented 9 years ago

Original comment by chadopp@gmail.com on 7 Feb 2012 at 2:56

GoogleCodeExporter commented 9 years ago

Original comment by chadopp@gmail.com on 9 Jun 2012 at 6:38