Recorded Shows page does not ignore "The" at the start of titles

chadopp / mythepisode

TV Series/Shows

2 stars 3 forks source link

Recorded Shows page does not ignore "The" at the start of titles #50

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Goto "Recorded TV Shows" page

What is the expected output? What do you see instead?
The Cleveland Show should be under "C" but it is under "T"

What version of the product are you using? On what operating system?
1.0.11 on Ubuntu 12.04 with MythTV 0.25.1

Please provide any additional information below.
I will look at the fix in the next couple of days - should be simple.

Original issue reported on code.google.com by alec.chr...@gmail.com on 7 Jun 2012 at 3:15

GoogleCodeExporter commented 9 years ago

I haven't looked at this code in a while.  I think I looked at fixing that a 
while back but found it was a bit more complicated than it seemed.  I hope you 
find it easy to fix.  I look forward to the patch.

Original comment by chadopp@gmail.com on 8 Jun 2012 at 4:09

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

Patch attached - please can you test?

Thanks.

Original comment by alec.chr...@gmail.com on 8 Jun 2012 at 10:33

Attachments:

[#50 The at start of titles.patch](https://storage.googleapis.com/google-code-attachments/mythepisode/issue-50/comment-2/#50 The at start of titles.patch)

GoogleCodeExporter commented 9 years ago

Alec...I've only been able to do minimal testing, but it appears to work great. 
 Thanks for the patch.

Original comment by chadopp@gmail.com on 8 Jun 2012 at 9:45

Added labels: Milestone-Release1.0.11

GoogleCodeExporter commented 9 years ago

Just found an issue.  There a double entries for different letters.  See 
attached file and notice 2 sections of A's and C's.

Original comment by chadopp@gmail.com on 8 Jun 2012 at 9:57

Attachments:

recorded.JPG

GoogleCodeExporter commented 9 years ago

Hmmm, you are right, why didn't I spot that?!

It would seem that this is because I am not looking for white-space after the 
"The" or "A" so it is treating "Access Holywood" as "Ccess Holywood" and 
putting it with the C's but then re-starting the section A when it gets there.

Is there a reason you remove the white space before the overrideFile section 
(about line 120 of main show.php)? It would be easier (for the "The" problem 
anyway) if we simply replaced any duplicate white-space with 1 single white 
space, do the overrideFile section, do the sort THEN remove all white-space - 
can you think of a reason why we couldn't do that? If not, see attached patch :)

Original comment by alec.chr...@gmail.com on 9 Jun 2012 at 8:51

Attachments:

#50.2.patch

GoogleCodeExporter commented 9 years ago

It's been a while since I've really messed with the code, so I can't say why we 
removed the whitespace.  I tested your patch and it seems to work as expected.  
I haven't found any adverse issues caused by the change.  Thanks for the patch. 
 I'm still running .22, so haven't done anything with .25.  Since you are 
running mythepisode trunk with .25 are you seeing any issues with defect 49?

Thanks,

Chad

Original comment by chadopp@gmail.com on 9 Jun 2012 at 6:12

GoogleCodeExporter commented 9 years ago

Original comment by chadopp@gmail.com on 13 Jun 2012 at 4:17

Changed state: Fixed