chadopp / mythepisode

TV Series/Shows
2 stars 3 forks source link

[Patch] Use MythTV's PHP bindings to retrieve current recordings #53

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Here's an initial relatively small change which eliminates one database round 
trip and uses the PHP bindings to retrieve a list of current recordings and 
turn them into Program objects (currently only on the episodes page). Future 
patches will build on this change.

Original issue reported on code.google.com by SiliconF...@gmail.com on 25 Oct 2013 at 5:49

Attachments:

GoogleCodeExporter commented 9 years ago
Note that there's something strange in two of the preg_replace calls, 
specifically these lines:
        $watchedEpisodes = preg_replace('/[^\w\d\s]+­/i', '', $watchedEpisodes);
...
        $unwatchedEpisodes = preg_replace('/[^\w\d\s]+­/i', '', $watchedEpisodes);

It doesn't show up in a web browser when you view the patch, but in the 
original episodes.php file that I got from SVN there was a screwy character 
after the + which showed up as a box in ssh to my Linux system, but Scite on 
Windows showed it as a - character. Dunno, but you might take a look at it. If 
it really is supposed to be a - character, you might want to just delete it and 
re-type it.

Original comment by SiliconF...@gmail.com on 25 Oct 2013 at 6:30

GoogleCodeExporter commented 9 years ago
Thanks Karl.  I'm on a business trip for the next several weeks so won't have 
much time to check this out.  Keep it coming though.  It looks like good stuff.

Original comment by chadopp@gmail.com on 27 Oct 2013 at 10:30

GoogleCodeExporter commented 9 years ago
Do you know what version of mythtv that the php bindings were introduced?

Original comment by chadopp@gmail.com on 28 Oct 2013 at 2:46

GoogleCodeExporter commented 9 years ago
From the ChangeLog notes, it looks like the PHP bindings showed up in 0.25. I 
don't know if you need to worry too much about maintaining compatibility with 
versions before that. You have a good released version that is compatible with 
old versions, but going forward I don't know if it's all that important. In any 
case, the changes that I've made could have logic to work around the lack of 
bindings.

Original comment by SiliconF...@gmail.com on 28 Oct 2013 at 3:16

GoogleCodeExporter commented 9 years ago
Yeah I don't think I want to waste too much time trying to remain compatible 
with versions too far back.

Original comment by chadopp@gmail.com on 1 Nov 2013 at 6:36