search

chadrem / market_bot

Google Play Android App store scraper
MIT License
361 stars 130 forks source link

Adds full-screenshot-urls support (high-res) #27

Closed JVillella closed 9 years ago

JVillella commented 9 years ago

Adds support for full-resolution screenshots on the product listing.

chadrem commented 9 years ago

Hi @JVillella and thank you for contributing to market_bot. Can you update the tests for your change? I want to avoid accepting untested changes so that future changes don't break yours.

All you need to do is edit ./spec/market_bot/android/app_spec.rb and then make sure rake spec runs without errors. It looks like there are 3 places in this file that need updated. You're going to want to add them right the existing tests for screenshot_urls. For example right after line 33 you can add the following to get started... app.full_screenshot_urls.should == ['fixme']

JVillella commented 9 years ago

Hi Chad, I'll do it asap thanks.