search

chadrem / market_bot

Google Play Android App store scraper
MIT License
361 stars 130 forks source link

adding developer_id method #61

Closed Simran1306 closed 7 years ago

Simran1306 commented 7 years ago

Hello there,

I just did the enhancement for getting developer_id of developer. If you look okay with code, please merge it with master or revert me with comments.

Thanks

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.0006%) to 99.75% when pulling 23cc0dccbc35383a80e9038eaa1f208ee8283f68 on Simran1306:providing-developer_id into 67b0cb48407f952da09c2455c10b83e302044f35 on chadrem:master.

chadrem commented 7 years ago

@Simran1306 Thanks for the pull request. Can you update spec/market_bot/play/app_spec.rb to include tests for your changes and make sure they all pass?

Let me know if you need help getting a test environment setup.

Also I just pushed some changes to update to the latest rspec and also fixed some Ruby 2.4.x warnings.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 99.5% when pulling 8cafc50f4797770013ea18ef84f8601197a3f9a5 on Simran1306:providing-developer_id into 67b0cb48407f952da09c2455c10b83e302044f35 on chadrem:master.

chadrem commented 7 years ago

@Simran1306 I've merged your code... thanks for adding the feature and test!