search

chadrem / market_bot

Google Play Android App store scraper
MIT License
361 stars 130 forks source link

Extracting Google Play info when classes are obfuscated #74

Closed refaelos closed 6 years ago

refaelos commented 6 years ago

We've found out that sometimes Google Play decides to obfuscate classes and then the whole process of market_bot fails. This fetches almost all of market_bot fields event when classes are obfuscated.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-14.4%) to 85.155% when pulling 1ad8ec3d0e849fdbed5d2757309e559a297c6e62 on soomla:master into 12836d4513441de244c2eeef542b8f57b13c50ab on chadrem:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-14.4%) to 85.155% when pulling 1ad8ec3d0e849fdbed5d2757309e559a297c6e62 on soomla:master into 12836d4513441de244c2eeef542b8f57b13c50ab on chadrem:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-14.4%) to 85.155% when pulling 1ad8ec3d0e849fdbed5d2757309e559a297c6e62 on soomla:master into 12836d4513441de244c2eeef542b8f57b13c50ab on chadrem:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-14.4%) to 85.155% when pulling 1ad8ec3d0e849fdbed5d2757309e559a297c6e62 on soomla:master into 12836d4513441de244c2eeef542b8f57b13c50ab on chadrem:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-16.8%) to 82.766% when pulling 2f35fd9a9823966631e8289523729eecd04fea12 on soomla:master into 12836d4513441de244c2eeef542b8f57b13c50ab on chadrem:master.

chadrem commented 6 years ago

@refaelos Thank you for the PR! I know a lot of people want to fix the scrapers. I can't accept this PR until the code coverage problem is fixed. This needs to be fixed so that future developers can keep the code from breaking. A few other people are working on fixing the scrapers in Issue #72 so it's possible they will want to help you with this.

refaelos commented 6 years ago

@chadrem I committed some fixes. Can you run the tests again? Also, can you show me how to see what is not covered?

chadrem commented 6 years ago

Closing this PR since #75 was merged. Thank you for your work on this!