search

chadrem / market_bot

Google Play Android App store scraper
MIT License
361 stars 130 forks source link

Fix for screenshot_urls and cover_image_url #76

Closed michaeldeol closed 6 years ago

michaeldeol commented 6 years ago

Our company is using this gem and we are grateful for the recent fix pushed to master. However, we found that there was a bug with screenshot_urls and cover_image_url.

cover_image_url was being overwritten by the screenshot_urls parse. In turn, screenshot_urls was not returning all screenshots.

I have updated the tests to reflect the change. I also removed the xit tests as these were no longer being parsed.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.003%) to 99.499% when pulling 9f13a48f849a36a7cd241bb63c173355ab684299 on GetBlast:fix_screenshot_url_bug into 669275575c006902b29a7a7948832dada688ed8d on chadrem:master.

chadrem commented 6 years ago

@michaeldeol thanks for the PR! Please track issue #72 to keep up to date with everyone who is interested in fixing the scrapers.