Guarded typing_extensions by version

ezragoss commented 1 year ago

Added version guards appropriate to typing_extensions
Made typing_extensions a required import for versions 3.7-3.9.* to match the version guards
Added poetry.lock to the gitignore

ezragoss commented 1 year ago

We're trying to get typing more widely adopted across the studio but our small team at IW has been typing new code for a little over a year (largely influenced, at least on our team, by what I learned at Luma). Most folks at different game studios I've spoken to seem to be interested in adopting static typing and a big obstacle is being able to handle untyped legacy code in a linting/typechecking pre-commit workflow so that's why I'm revisiting typeright. Mostly it would be nice to have it in my back pocket as an auto-typing solution whether professional or personal.

Maybe for legal reasons I should say these are personal contributions on personal time haha

ezragoss commented 1 year ago

Ok I also added a pre-commit fix and linked the relevant source for changing the isort version in pre-submit hooks. Let me know if you'd rather I break up those commits

chadrik commented 1 year ago

Looks good, thanks!

You may also be interested in this new project that I'm working on: https://github.com/LumaPictures/cg-stubs/

I'll be getting them all onto pypi by early next week.

chadrik / typewriter

Guarded typing_extensions by version #10