Slave pens don't work and have a hidden slave cost

[Harmandodelavega]

Mby fixed around 4.1

The diktat discount part got apparently fixed in 4.12

[mfvreeland]

From 4.1.2 notes: "The Slave Pens building will now correctly reduce the cost of Diktats in the local province."

[floskan]

https://community.creative-assembly.com/total-war/total-war-warhammer/bugs/1157-slave-pens-and-slave-market?page=1

The scope is region_to_region_own_provincewide instead of building_to_province_own

[Drazhir2]

Had a look after the report from #1810

It doesn't seem to work

[floskan]

Haven't had time to test this since I put this out, but I can't see why it wouldn't work, at least dcopewise

[Bebelmondo]

Just to confirm that Drazhir is right. region_to_region_own_provincewide doesn't work sadly.

[mfvreeland]

So have we determined that this isn't fixable?

[floskan]

Haven't looked into it beyond changing scope, but maybe the effect itself is borked

[mfvreeland]

Maybe a faction scope would work?

[floskan]

yeah faction to province might work

[mfvreeland]

What about building to faction? The effect is coming from a building, so I think that part is right, but wherever it's directed needs to be compatible with the effect(s). I would just try building to x until something takes.

[floskan]

Lol i don't really want to admit this but aren't i using the wrong effect in this fix Nope, false alarm

[mfvreeland]

Maybe fixed for real now? @floskan "Fixed an issue where Dark Elf buildings that reduce slave count only functioned correctly when constructed by the player. Captured settlements with pre-existing economic buildings did not reduce slave count until these buildings were upgraded or replaced. This fix ensures that the slave count reduction feature works as intended immediately upon acquiring such buildings."

[floskan]

Not the same issue, I tried different potential fixes on a turn one save with my starting settlement. Need to try it out!