chadvandy / cbfm_wh3

Community Bug-Fix Mod for Warhammer III. Please feel free to make pull requests, issues, etc!
40 stars 32 forks source link

Skaven plagues not applying after agent action. #147

Closed jtslugmaster08 closed 2 years ago

jtslugmaster08 commented 2 years ago

Reproduction steps.

  1. Unlock rite to spawn a plague agent.
  2. Use agent on any enemy city.
  3. Confirmation of plague success will appear however there is no indication of a plague being spread nor is the plague affect applied either.

Additional notes. I tested on Clan pestilence, but I did hear from others in the steam comment section that it was for other skaven factions as well.

mfvreeland commented 2 years ago

I don't think this is fixable via mod. The bonus value that triggers the code to start a plague does not seem to work at all unless there is a Nurgle plague type assigned, and there seems to be no way outside of code to assign a Nurgle plague type (not that this would really fix the issue, either, since Skaven plagues should not be Nurgle plagues).

TheTiberon commented 2 years ago

Not sure if this helps but the Clan Pestilens unique undercity building (Grand Plague Cauldron) correctly applies and spreads a skaven plague to the immediate and surrounding regions and armies.

20220921132933_1 20220921132958_1 20220921133007_1 20220921133453_1

mfvreeland commented 2 years ago

@TheTiberon That's very interesting. I'll dig into this again and see what I can find...

chadvandy commented 2 years ago

the building uses a script to apply the plague. It looks like the infect_with_plague action outcome exclusively works with Nurgle plagues at the moment. A fix could be using a script to listen for this through a https://chadvandy.github.io/tw_modding_resources/WH3/scripting_doc.html#CharacterGarrisonTargetAction event

mfvreeland commented 2 years ago

the building uses a script to apply the plague. It looks like the infect_with_plague action outcome exclusively works with Nurgle plagues at the moment. A fix could be using a script to listen for this through a https://chadvandy.github.io/tw_modding_resources/WH3/scripting_doc.html#CharacterGarrisonTargetAction event

Sounds doable. I'll give it a shot.

mfvreeland commented 2 years ago

Fixed by CA in 2.2, should be removed

chadvandy commented 2 years ago

removed