search

chadvandy / cbfm_wh3

Community Bug-Fix Mod for Warhammer III. Please feel free to make pull requests, issues, etc!
40 stars 32 forks source link

Waaagh doesn't get upgraded to Big Waaagh when Waaagh gets called #1548

Closed floskan closed 2 months ago

floskan commented 4 months ago

Applies to generic and LL Waaaghs Skärmbild 2024-04-13 153931 Skärmbild 2024-04-13 160922

floskan commented 4 months ago

Works for the player Skärmbild 2024-04-13 163548

Skärmbild 2024-04-13 163541

Harmandodelavega commented 4 months ago

some wh2 bugs which might have not been fixed https://github.com/chadvandy/cbfm_wh3/issues/709 https://github.com/chadvandy/cbfm_wh3/issues/710

mfvreeland commented 4 months ago

Reposting from Discord: I had a chance to dive a little deeper into the campaign waaagh script, and while I don't really understand their thinking behind it, it seems pretty clear that CA definitely intended for the upgraded waaagh abilities to only go to the player(s). There are numerous explicit checks for whether or not the faction in question is human-controlled made before every instance that updates these abilities. It was undoubtedly designed this way on purpose, which makes its status as a bug questionable (unlike the AI not using the basic abilities in battle, which I think absolutely is a bug).

I still think it could be changed so the AI gets the upgraded abilities, but I'm iffy about adding this to CBFM now.

floskan commented 4 months ago

I'm fine with whatever! What we have with the fix is still miles better then nothing

Harmandodelavega commented 4 months ago

Did the AI get it in WH2? I think that would settle it Edit: Although there's a separate problem in WH3 that the AI basically has a permaWaagh going for whatever reason

floskan commented 4 months ago

Seems like the ai starts with higher base reputation after finishing their waaagh then the player does

mfvreeland commented 4 months ago

The AI also semi-randomly gets reputation boosts. Basically, their design is totally different, presumably because CA didn't think the AI could normally perform well enough to get Waaaghs. It's a system that could probably use retuning, but I worry that messing with it gets into the realm of balancing more than bug fixing.

mfvreeland commented 4 months ago

FYI, this does not appear to have been changed in 5.0 (script still explicitly limits Big Waaaagh abilities to human players). I am still chalking this up to CA design, however mysterious.