chadvandy / cbfm_wh3

Community Bug-Fix Mod for Warhammer III. Please feel free to make pull requests, issues, etc!
40 stars 32 forks source link

Ironbrows weapon shops has odd effects (dwarfs) #1733

Open floskan opened 4 months ago

floskan commented 4 months ago

"This land mark gives +%5 weapon dmg 'Against' dwarfs. Which is weird also its 10 armor to shielded units in region is pretty useless. Can you guys give it a look to these effects? Side note belegars campaign special building in 8 peaks gives faction wide magical attacks. Can somehow this can be for also other lords? Dwarfs lack magical attacks in general."

https://community.creative-assembly.com/total-war/total-war-warhammer/bugs/1171-dwarf-land-mark-ironbrow-s-weapons-shops?page=1

mfvreeland commented 3 months ago

Questionable design, perhaps, but not really a bug.

floskan commented 3 months ago

It had a different effect a few patches ago. "Weapon strength: +5% for Dwarf units with hand weapons (local armies)" which makes more sense (to me)

mfvreeland commented 3 months ago

It makes more sense to me, too; I'd just want a little more confirmation that the change was unintentional. I'm not going to close this issue, though, because it is odd.

Drazhir2 commented 3 months ago

It had a different effect a few patches ago. "Weapon strength: +5% for Dwarf units with hand weapons (local armies)" which makes more sense (to me)

I agree that your effect makes more sense. May I ask where you saw that? my git-fu failed me and all I could find is this change that happened in patch 3.0.0:

image

allenhu0912 commented 3 months ago

I recall seeing that in WH2.

floskan commented 3 months ago

Yeah I think Allen is correct, I might have selective memory. But I still think this new effect was an error lost in translation between games or something

mfvreeland commented 2 months ago

This was recently brought up on Discord, and there is a growing consensus that although this has been this way in WH3 for a long time, it was a regionwide weapon strength buff in WH2, and that just makes too much more sense not to implement. I am inclined to agree at this point.

Note it's still basically a non-factor, but just for flavor we may as well change it. It could help the garrison, albeit insignificantly.