chadvandy / cbfm_wh3

Community Bug-Fix Mod for Warhammer III. Please feel free to make pull requests, issues, etc!
40 stars 32 forks source link

Impossible to Confederate Minor Dwarven Factions eg Zhufbar #1752

Open floskan opened 5 months ago

floskan commented 5 months ago

"With the Book of Grudges rework allowing for confederation of major factions and their LL, it now appears that it is impossible to confederate any of the smaller factions due to the confederation being removed as a dimplomacy option for all dwarf factions."

https://community.creative-assembly.com/total-war/total-war-warhammer/bugs/1304-impossible-to-confederate-minor-dwarven-factions-eg-zhufbar?page=1

mfvreeland commented 5 months ago

Could be intentional.

DrDCB commented 4 months ago

Dwarf confederation is locked via the apply_default_diplomacy function in script\campaign\wh_campaign_setup.lua searching for factions in the dwarf_playable_factions set :

-- If there are any human dwarf factions block confederation between the Legendary Lords
if human_dwarf_faction then
    for _, source_faction in model_pairs(dwarf_playable_factions) do
        for __, target_faction in model_pairs(dwarf_playable_factions) do
            if source_faction ~= target_faction then
                cm:force_diplomacy("faction:" .. source_faction:name(), "faction:" .. target_faction:name(), "form confederation", false, false, true)
            end
        end
    end
end

The factions in the set as defined in db\faction_set_items_tables:

id culture faction remove set subculture
1245378925 wh_main_dwf_dwarfs false dwarf_playable_factions
1139157765 wh_main_dwf_karak_izor false dwarf_playable_factions
1196225252 wh_main_dwf_karak_kadrin false dwarf_playable_factions
764272554 wh2_dlc17_dwf_thorek_ironbrow false dwarf_playable_factions
1852398745 wh3_main_dwf_the_ancestral_throng false dwarf_playable_factions
480430056 wh3_dlc25_dwf_malakai false dwarf_playable_factions

It shouldn't affect Zhufbar or the other minor Dwarf factions. It's possible something is breaking somewhere though, possibly via mods or something else, as I found that Thorek was able to be confederated via diplomacy when I discovered him around turn 60ish in a current Dwarf campaign. He should only be able to be confederated via the grudge mechanic. Belegar was working as intended earlier in the campaign (could only be confederated through the book).