chadvandy / cbfm_wh3

Community Bug-Fix Mod for Warhammer III. Please feel free to make pull requests, issues, etc!
40 stars 32 forks source link

Beastmen army ability Vile Entropy can affect a unit more than once #1913

Open SubRyan opened 2 months ago

SubRyan commented 2 months ago

Describe the bug The army ability Vile Entropy can affect a unit more than once if the uit moves in and out of the aura, or moves from a wall to the ground within the aura

Expected behavior Vile Entropy ability is changed so that it imbues an effect which then only applies the debuffs. The effect is then checked for within the aura and is not applied again

To Reproduce Steps to reproduce the behavior:

  1. Play as Beastmen
  2. Construct the Pile of Flesh horde building
  3. Enter a siege battle or a battle against fast moving missile units
  4. Activate Vile Entropy on a wall or on missile units
  5. Units should be affected twice if they move within the aura as described above

Screenshots

Saves If this is a hard-to-reproduce problem and you have a save game, please provide your save game! They are located in AppData/Roaming/The Creative Assembly/Warhammer3/save_games/

Additional context This a pain in the ass to confirm as Beastmen army abilities are not available to test in Skirmish mode

mfvreeland commented 2 months ago

The easy (possibly only?) way to fix this would be to simply disable the "updates targets every frame" checkbox for this ability, but that would mean that the units that started in the AoE would keep the range debuff for the duration even if they left the circle (and no units entering the circle after the ability started would be affected).

Do we think this is a worthwhile tradeoff?

More context: I don't know if it's possible to have one ability trigger another ability, so I doubt there's another solution. Abilities can have multiple phases, but the "updates targets every frame" setting is applied at the ability level, not the phase level, so it's not possible to change this setting mid-ability.