Assorted Empire politics bugs

[Harmandodelavega]

Old WH2 fixes:

https://trello.com/c/6UgcSaKK/237-missing-demand-return-dilemmas-for-pfeildorf-and-steingart (#513 and #551) https://trello.com/c/ZPuKwoKX/119-missing-option-to-resurrect-golden-order-when-capturing-pfeildorf (fix seems obsolete) https://trello.com/c/q9c8prs0/227-no-fealty-bonus-for-returning-reinstating-pfeildorf-steingart https://trello.com/c/w7LLdxh2/140-empire-spy-guild-region-visibility-not-working-at-all https://trello.com/c/IO2EBGVL/124-empire-interventions-take-an-already-recruited-lord-at-random-from-your-pool-and-kill-it-after-the-battle-is-done #489 https://trello.com/c/OqBlEkbK/591-imperial-intervention-battle-targets-invalid-generals https://trello.com/c/Wd0CmYge/583-for-imperial-intervention-battle-the-ancillary-event-message-should-be-hidden https://trello.com/c/Xn4nV9xN/587-regions-in-the-bloodgrounds-can-be-returned-to-an-elector-count https://trello.com/c/qP9FK5Ns/337-elector-counts-first-time-occupying-a-capital-advice-message-trigger-condition-wrong https://trello.com/c/3meS7fEm/336-attacked-recently-returned-region-not-working-as-intended https://trello.com/c/SxrRwxWQ/355-empire-invasion-trespassing-bug https://trello.com/c/EiMbh0YH/152-trespassing-penalty-after-returning-a-settlement-to-an-elector

new reports:

513 #551

gmoulin The fealty increase change per turn and count is 5% per tooltip when the imperial authority is positive (>0). In a 50+ turn campaign, it never triggered once. Something seems really bugged. sm0kin Seems like the "wh2_dlc13_emp_elector_prestige_endgame_1" Guilded Opportunity endgame prestige dump dilemma is missing in wh3. Subjugated Elector Counts can still get realms returned to them while staying vassals Sometimes, Marienburg (or other Empire) Generals are assigned as Elector Counts of provinces that Marienburg definitely doesn't own.

[mfvreeland]

Are these issues all confirmed still busted in WH3? I may take a crack at these eventually, since they're all script-related.

[Harmandodelavega]

@mfvreeland I'm not a scripter but I verified what I could, they were there in WH2 and I'll bet most of them still are

[floskan]

@mfvreeland Would adding to the politics script work? Everything that was in the db in 2 is still there in 3

[Drazhir2]

just that bit is not enough, that's the definition of a function but it's not getting called anywhere, also empire_prestige_event_level doesn't exist in the wh3 script.

You'd have to add:

• the bit that calls empire_attempt_prestige_dilemma in empire_process_faction
• the empire_prestige_event_level variable definition/init + the save/load_named_value bits for it

[mfvreeland]

Are these still relevant since the Empire rework?