chadw75 / tunnelblick

Automatically exported from code.google.com/p/tunnelblick
0 stars 0 forks source link

client.up.osx.sh missing patch #72

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Please merge this into the next tunnelblick version:

--- client.up.osx.sh    2008-07-24 22:06:25.000000000 +0200
+++ client.up.osx.sh    2008-10-01 10:34:07.000000000 +0200
@@ -104,7 +104,7 @@
 scutil << EOF
 open
 d.init
-d.add ServerAddresses * $vDNS
+d.add ServerAddresses * ${vDNS[@]}
 d.add DomainName $domain
 set State:/Network/Service/${PSID}/DNS
 quit

When pushing more than one nameservers, we need to pass *all of them*
to scutil with an *array*.

See http://tldp.org/LDP/abs/html/arrays.html for more details. 

Kind regards
Thomas

Original issue reported on code.google.com by thomas.r...@googlemail.com on 22 Feb 2009 at 9:33

GoogleCodeExporter commented 9 years ago

Original comment by jkbull...@gmail.com on 4 Oct 2009 at 3:47

GoogleCodeExporter commented 9 years ago
Do you think that "WontFix" is an appropriate answer after 7,5 months? Don't you
agree that setting just *one* nameserver is a wrong? Don't you agree that 
openvpn can
pass more than just *one* nameserver via push "dhcp-option dns"? Quoting the 
manpage:

              DNS addr -- Set primary domain name server address.  Repeat this
              option to set secondary DNS server addresses.

So after all, don't you agree that $vDNS is an array?

Well obviously WONTFIX is the correct answer, as this WONTFIX sucks since soooo 
many
months and noone ever tried to get this WONTFIX right. WONTFIX my ass.

WONTIFX regards,
Thomas

Original comment by thomas.r...@googlemail.com on 4 Oct 2009 at 6:48

GoogleCodeExporter commented 9 years ago
This was marked "WontFix" because the scripts have been replaced. The patch no 
longer applies.

Original comment by jkbull...@gmail.com on 4 Oct 2009 at 7:13