search

chadxz / awry

An Asterisk REST Interface (ARI) websocket and API client library
MIT License
21 stars 9 forks source link

Expose ping. Needs tests and review. #105

Closed chadxz closed 1 year ago

chadxz commented 5 years ago

Closes #103

chadxz commented 5 years ago

@goldiv Would this API work for you for ping? Namely, do you use the callback or would you be fine with receiving any error from the ping as an event?

This feature still needs tests but I wanted to make sure i'm solving your problem before I write them.

codecov[bot] commented 5 years ago

Codecov Report

Merging #105 into master will decrease coverage by 1.77%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage     100%   98.22%   -1.78%     
==========================================
  Files          15       15              
  Lines         387      394       +7     
==========================================
  Hits          387      387              
- Misses          0        7       +7
Impacted Files Coverage Δ
src/events/ReconnectingWebSocket.js 91.02% <0%> (-8.98%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 315ef7f...0dee1a2. Read the comment docs.