search

chadxz / imap-simple

Wrapper over node-imap, providing a simpler api for common use cases
MIT License
245 stars 79 forks source link

Feature/gmail specific functions #73

Closed lou-bi closed 3 years ago

lou-bi commented 4 years ago

This pull request add two functions - available only for Gmail client, regarding the node-imap documentation -, to set and remove labels.

They have been tested on a project of mine, and were able to do what was expected. Even if in the node-imap documentation, label are plural on the functions name, I keep the way of how was written the addMessageLabel to avoid unconsistency.

The documentation have been updated to mention them.

As this pull request adds functions, I have increase the package version.

I hope to have done everything perfect for the first ever pull request in my life, and I'm happy to do it with you !

glensc commented 3 years ago

Things you shouldn't do in a feature pull request:

  1. make unrelated formatting changes
  2. bump a version