search

chaehyeonsong / discocal

150 stars 21 forks source link

not supproted .bmp format #14

Open spdfghi opened 3 months ago

spdfghi commented 3 months ago

I have run the code and got "terminate called after throwing an instance of 'DeficientImagesException'", then I find it only supporting jpg or png in line 47, mono.cpp

spdfghi commented 3 months ago

@chaehyeonsong

spdfghi commented 3 months ago

disk.zip I have got a reproject error 0.0558, but Calibration Quality: 68.656589 %. As in other issue, the problem is that I did not take photos at diffrent distances? Is there any literature tell us how to make better photos?

chaehyeonsong commented 3 months ago

@spdfghi Could you tell me the length of the circle radius and distance?

spdfghi commented 3 months ago

@chaehyeonsong r=0.45 and d=1, board is here: diskboard.pdf made by mathematica code

chaehyeonsong commented 3 months ago

@spdfghi . I examined the dataset. The main problem is deficient images. You need to extend the image sets I recommend to include closer scenes and farther scenes (closer scenes are important). Moreover, increase the circle radius and decrease the number of circles. (3x5 grid might be appropriate in your case)

spdfghi commented 3 months ago

@chaehyeonsong Thanks, I will try. And could you provide a more theoretical explanation for why? In the papers I have read, it is mentioned that the calibration distance and measurement distance should be close