Closed simonmd closed 10 years ago
Oops. I seem to have requested a merge to the master branch (which doesn't have code), not the Github pages branch. Do you want me to close it, or do you want to update the master with the actual code?
Might as well move it all to master so people can actually find it. I thought the github pages was the right way to do this but I am not sure if there is any benefit of using it over rawgithub.
On Sun, May 11, 2014 at 2:16 PM, Simon Rascovsky notifications@github.comwrote:
Oops. I seem to have requested a merge to the master branch (which doesn't have code), not the Github pages branch. Do you want me to close it, or do you want to update the master with the actual code?
— Reply to this email directly or view it on GitHubhttps://github.com/chafey/cornerstoneDemo/pull/17#issuecomment-42780021 .
OK. So I guess if you merge this PR, master will have all the code + my small tweaks. Here's a screenshot of changes so far:
Nice, now I can see the UI was influenced by a radiologist :) I haven't accepted a pull request before so I have to figure that out - will do so after the poster is done :)
Chris
On Sun, May 11, 2014 at 2:39 PM, Simon Rascovsky notifications@github.comwrote:
OK. So I guess if you merge this PR, master will have all the code + my small tweaks. Here's a screenshot of changes so far:
[image: screen shot 2014-05-11 at 2 13 57 pm]https://cloud.githubusercontent.com/assets/155209/2939358/f5b0c06e-d943-11e3-8ebb-b15466dc8651.png
— Reply to this email directly or view it on GitHubhttps://github.com/chafey/cornerstoneDemo/pull/17#issuecomment-42780617 .
Made some color and text size changes to make it more subtle. Also included CSS to fix 'bouncing' when scrolling (Issue #8)