search

chafey / cornerstoneDemo

Demonstration application that shows use of all cornerstone components together
71 stars 67 forks source link

Resizing browser messes up hidden image tab layout #3

Closed boxerab closed 10 years ago

boxerab commented 10 years ago

Steps to repro:

1) open multiple image tabs 2) click on tab A 3) resize browser 4) switch to tab B

Layout is now messed up. Resizing again will fix for this tab, but then other tabs will be broken.

imanabu commented 10 years ago

Confirmed on Chrome Mac 34.0.1847.131, Mac FF 29.0

Same behavior, when getting back to the previously hidden tab, the control palette aligns vertically to the left, image is blank and then the thumbnails shows about top 1/2 of the image.

Workaround: Resize the panel again and everything is back to normal for the panel, but it affects the others.

chafey commented 10 years ago

This is easy to fix, just need to detect window resize and call resize() on the element. I just added resize a few weeks back and never updated the demo app...

On Mon, May 5, 2014 at 4:17 PM, Manabu Tokunaga notifications@github.comwrote:

Confirmed on Chrome Mac 34.0.1847.131, Mac FF 29.0

Same behavior, when getting back to the previously hidden tab, the control palette aligns vertically to the left, image is blank and then the thumbnails shows about top 1/2 of the image.

Workaround: Resize the panel again and everything is back to normal for the panel, but it affects the others.

— Reply to this email directly or view it on GitHubhttps://github.com/chafey/cornerstoneDemo/issues/3#issuecomment-42240790 .

boxerab commented 10 years ago

Cool. Perhaps you can mark the hidden tabs as dirty, and only resize them when they become visible.

chafey commented 10 years ago

I'll fix this soon, just finishing up some things in the underlying libraries for I work on the demo app again

On Tue, May 6, 2014 at 6:57 AM, Aaron Boxer notifications@github.comwrote:

Cool. Perhaps you can mark the hidden tabs as dirty, and only resize them when they become visible.

— Reply to this email directly or view it on GitHubhttps://github.com/chafey/cornerstoneDemo/issues/3#issuecomment-42293638 .

boxerab commented 10 years ago

Great. Looking very good overall, by the way.

chafey commented 10 years ago

This issue should now be fixed, can you guys please verify? Thanks

boxerab commented 10 years ago

working now. thx.