search

chaiNNer-org / chaiNNer

A node-based image processing GUI aimed at making chaining image processing tasks easy and customizable. Born as an AI upscaling application, chaiNNer has grown into an extremely flexible and powerful programmatic image processing application.
https://chaiNNer.app
GNU General Public License v3.0
4.6k stars 283 forks source link

Release Flatpaks and publish on FlatHub #1597

Open ghost opened 1 year ago

ghost commented 1 year ago

Would be great to have this app on FlatHub, both x86 and aarch64

joeyballentine commented 1 year ago

I tried this somewhat recently, but the electron-forge flatpak builder has some kind of bug that caused it to fail to build, and the author said he didn't have time to look into it. So until that's fixed we can't build as flatpak.

I could try setting it up again though, and just see if it's been fixed since.

Efenstor commented 1 year ago

How about reviving the idea of Flatpak packaging? After all it's is the most convenient way for many modern distros to keep recent apps safe and fresh. May be the bug in electron-forge was fixed?

joeyballentine commented 1 year ago

I can look into it again when I have some time. I would like it to work, so hopefully the problems have been fixed. I will let you know. (It'll be a few days before I can try this though)

Efenstor commented 1 year ago

That would be great!

refi64 commented 1 year ago

the electron-forge flatpak builder has some kind of bug that caused it to fail to build

Is there any record on what the issue looked like / what the symptoms were?

joeyballentine commented 1 year ago

@refi64 a couple weeks ago, @stonerl looked into this again and ran into issues again. It appears there's just a bug with the electron-forge flatpak builder. He asked in the electron discord and the forge devs haven't responded as far as I know.

stonerl commented 1 year ago

@refi64 It is an Exit Code 1 error without any further information, even in debug.

The way to go here would be, to omit electron-forge for flatpaks and use flathub directly.

But currently I'm quite busy and don't have much time to peruse this any further.

Arcitec commented 3 weeks ago

@joeyballentine Electron is Chromium-based and every Chromium-based app needs some weird patch/wrapper when running inside Flatpaks.

This is possibly the reason.

This is the wrapper literally everybody uses:

https://github.com/refi64/zypak

(And yes I realize the irony that @refi64 is in this thread already. I recognized the name. :D)

Here's an example Flatpak yaml where Brave Browser uses zypak:

https://github.com/flathub/com.brave.Browser/blob/master/com.brave.Browser.yaml